Rework room summary

[ganfra]

Content

This PR takes care of 3 things :

• Do not use RoomSummary directly in the ui model, so creates new models when necessary
• Let RoomSummary uses RoomInfo directly instead of mapping partial data.
• Rework the getRoomInfoFlow to not use getRoom internally.

Motivation and context

Better code and prepare work for knocking feature.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/A9cqFp

[bmarty]

LGTM, thanks!

[bmarty]

Move function toSelectRoomInfo() from the test class to this file and use it here?

[bmarty]

We will probably want to do the same type of rework for Member.roomMember (later!)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov]

Codecov Report

Attention: Patch coverage is 96.27119% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (5a4e5d0) to head (5afa7f6).
Report is 42 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ns/edit/EditDefaultNotificationSettingPresenter.kt	83.33%	1 Missing and 2 partials ⚠️
...list/impl/datasource/RoomListRoomSummaryFactory.kt	90.47%	0 Missing and 2 partials ⚠️
...oser/suggestions/RoomAliasSuggestionsDataSource.kt	87.50%	0 Missing and 1 partial ⚠️
...cations/edit/EditDefaultNotificationSettingView.kt	66.66%	0 Missing and 1 partial ⚠️
...ndroid/libraries/matrix/api/room/MatrixRoomInfo.kt	80.00%	1 Missing ⚠️
...oid/libraries/matrix/ui/components/SelectedRoom.kt	90.00%	1 Missing ⚠️
...ries/roomselect/impl/RoomSelectSearchDataSource.kt	66.66%	0 Missing and 1 partial ⚠️
...ndroid/libraries/roomselect/impl/RoomSelectView.kt	88.88%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3631      +/-   ##
===========================================
+ Coverage    82.65%   82.72%   +0.06%     
===========================================
  Files         1735     1738       +3     
  Lines        41191    41227      +36     
  Branches      4999     4999              
===========================================
+ Hits         34047    34104      +57     
+ Misses        5381     5359      -22     
- Partials      1763     1764       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.