Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'document' case for message with timestamp preview #2164

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

jmartinesp
Copy link
Member

@jmartinesp jmartinesp commented Jan 4, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : remove no longer used previews.

Content

Removes all the 'document' case previews for messages with timestamps, which were related to using Jsoup for parsing the HTML contents.

Motivation and context

Fixes #2127 .

Screenshots / GIFs

In the PR.

Checklist

@jmartinesp jmartinesp marked this pull request as ready for review January 4, 2024 13:29
@jmartinesp jmartinesp requested a review from a team as a code owner January 4, 2024 13:29
@jmartinesp jmartinesp requested review from bmarty and removed request for a team January 4, 2024 13:29
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/55ERpk

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2a7b38) 66.97% compared to head (63d6c42) 67.02%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2164      +/-   ##
===========================================
+ Coverage    66.97%   67.02%   +0.05%     
===========================================
  Files         1375     1375              
  Lines        34219    34181      -38     
  Branches      7544     7446      -98     
===========================================
- Hits         22919    22911       -8     
+ Misses        7663     7653      -10     
+ Partials      3637     3617      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 0ca9780 into develop Jan 4, 2024
16 checks passed
@jmartinesp jmartinesp deleted the misc/jme/2127-remove-unneeded-extra-previews branch January 4, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Document case in preview
2 participants