-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MSC4027 (Custom images in reactions) #2160
Conversation
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
Signed-off-by: Marco Antonio Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working quite well, thanks! There are a couple of issues that should be fixed before it's merged, though.
...nt/android/features/messages/impl/timeline/components/reactionsummary/ReactionSummaryView.kt
Outdated
Show resolved
Hide resolved
...tlin/io/element/android/features/messages/impl/timeline/components/MessagesReactionButton.kt
Show resolved
Hide resolved
...tlin/io/element/android/features/messages/impl/timeline/components/MessagesReactionButton.kt
Outdated
Show resolved
Hide resolved
...nt/android/features/messages/impl/timeline/components/reactionsummary/ReactionSummaryView.kt
Outdated
Show resolved
Hide resolved
move emoji line height to a private value Signed-off-by: Marco Antonio Alvarez <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2160 +/- ##
===========================================
- Coverage 66.97% 66.95% -0.03%
===========================================
Files 1375 1375
Lines 34219 34236 +17
Branches 7544 7546 +2
===========================================
+ Hits 22919 22922 +3
- Misses 7663 7675 +12
- Partials 3637 3639 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marco Antonio Alvarez <[email protected]>
...ents_MessagesReactionButton_null_MessagesReactionButton-Day-11_11_null_0,NEXUS_5,1.0,en].png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, LGTM! You might need to add an empty commit at the end so the CI runs again (stupid GH limitations for PRs coming from forks & CI-generated commits, sigh).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @surakin !
Can I ask you to add a comment on this PR with screenshot with the 2 rendering using the latest code:
- timeline message with mxc reaction
- bottom sheet of the details of this image.
Thanks!
Fixes #2159
Type of change
Content
Implement rendering of custom images in reaction per MSC4027
Motivation and context
Ran into mxc reactions while testing Element X and wanted to make it work
Screenshots / GIFs
Tests
Tested devices
Android 6, 13, 14
Checklist