-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpile @vector-im/compound-web with babel #25906
Conversation
@germain-gg could you include the rationale for this in the PR description? Why not just consume the built artifacts from the library like we do for the vast majority of our dependencies (both internal & external) |
@t3chguy we essentially need it because it otherwise throws
We still use the But our webpack/babel setup is tricking us in having to do it anyway. And i'm not looking to fix this at this stage. |
webpack.config.js
Outdated
// either webpack or our babel setup. | ||
// When we do get to upgrade our current setup, this should | ||
// probably be removed. | ||
if (f.includes("compound-web")) return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we be more specific, there might be transitive imports which also contain the text compound-web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #25905
For #25883
To review alongside matrix-org/matrix-react-sdk#11354
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.