Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Giphy integration #16808

Closed
wants to merge 7 commits into from
Closed

Document Giphy integration #16808

wants to merge 7 commits into from

Conversation

panagiotis-c
Copy link

@panagiotis-c panagiotis-c commented Mar 28, 2021 •
edited by github-actions bot
Loading

Associated PR: matrix-org/matrix-react-sdk#5814

Signed-off-by: Panagiotis Chalimourdas [email protected]

This change is marked as an internal change (Task), so will not be included in the changelog.

@panagiotis-c panagiotis-c mentioned this pull request Mar 28, 2021
Closed
10 tasks
@jryans jryans changed the title document giphy integration Document giphy integration Mar 30, 2021
@jryans jryans changed the title Document giphy integration Document Giphy integration Mar 30, 2021
@SimonBrandner
Copy link
Contributor

@panoschal, I think the merge broke your PR :P
Screenshot_20210509_204042

@tsukasagenesis
Copy link

If someone can look into it

@t3chguy t3chguy requested a review from a team June 30, 2021 16:33
t3chguy
t3chguy requested changes Jun 30, 2021
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs DCO sign-off (see https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.rst#sign-off) and the tests passing

@Palid
Copy link
Contributor

Palid commented Aug 19, 2021

Is this still relevant? @panoschal
New sign-off link: https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md#sign-off

@SimonBrandner
Copy link
Contributor

Is this still relevant? @panoschal

Definitely, the react-sdk PR is waiting for design/product review though, so this is quite stuck... Perhaps someone could give them a nudge

@SimonBrandner SimonBrandner added the T-Task Tasks for the team like planning label Aug 19, 2021
SimonBrandner
SimonBrandner suggested changes Aug 19, 2021
View reviewed changes
docs/labs.md Outdated Show resolved Hide resolved
@SimonBrandner
Copy link
Contributor

Your CI is failing because it using your develop branches from the other layers. You'll have to merge and push on these too

SimonBrandner
SimonBrandner approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@panagiotis-c
Copy link
Author

Great! I signed in the PR description.

@panagiotis-c panagiotis-c requested a review from t3chguy August 19, 2021 12:30
@SimonBrandner
Copy link
Contributor

Marking as blocked since the react-sdk PR hasn't been merged yet

@t3chguy
Copy link
Member

t3chguy commented Apr 27, 2023

The associated PR this was for got closed

@t3chguy t3chguy closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy

Assignees
No one assigned
Labels
T-Task Tasks for the team like planning X-Blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@panagiotis-c @SimonBrandner @tsukasagenesis @Palid @t3chguy