Point to #develop and use the same gemini-scrollbar version as the react-sdk #10893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Might fix an issue?
turt2live
changed the title
jryans
approved these changes
Sep 17, 2019
|
This one is missing the change to |
jryans
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10894 for why we're using develop. The gemini-scrollbar upgrade is just cleanliness (no material change).
It's safe to point at develop even though yarn doesn't build the dependency because we end up building the dependency when we
startorbuildlater.Should be reviewed with matrix-org/matrix-react-sdk#3451