Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider not showing edit messages when "Show hidden events in timeline" is on #9937

Closed
anoadragon453 opened this issue Jun 3, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3057
Closed

Consider not showing edit messages when "Show hidden events in timeline" is on #9937

anoadragon453 opened this issue Jun 3, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3057
Assignees
@jryans
Labels
T-Defect

Comments

@anoadragon453
Copy link
Member

image

Description

It's nice to have the "Show hidden events in timeline" options on, but it can be annoying when edits are displayed separately from the edited message, especially when it comes right after the original message (now displayed as edited), which it often does.

Even with this on we are unable to see the previous message, so doubling the message shows nothing new, and I believe adding a special case to hide the duplicated event would be a nice quality of life improvement.

Steps to reproduce

  • Turn "Show hidden events in timeline" on in Labs
  • Send a message
  • Edit a message
  • Now there's two very similar messages in the timeline

Version information

  • Platform: web
  • Browser: Firefox
  • OS: Debian Stretch
  • URL: riot.im/develop
@anoadragon453
Copy link
Member Author

Or alternatively display them in a collapsed fashion as we do reactions:

image

@jryans
Copy link
Collaborator

jryans commented Jun 3, 2019

I think showing them as a collapsed source view is more useful for debugging.

@jryans jryans self-assigned this Jun 3, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 3, 2019
@jryans
Allow source tile handler for replacements
b309ebf 
If the debugging mode of showing hidden events in the timeline is enabled, we
should also show replacements using the same view source tile as we do for
reactions. This allows easy debugging of replacement event data and also makes
the edit event look visually distinct from regular messages.

Fixes element-hq/element-web#9937
@jryans jryans mentioned this issue Jun 3, 2019
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow source tile handler for replacements matrix-org/matrix-react-sdk
2 participants
@jryans @anoadragon453