You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the request of the team, this is an epic to track the missing things from the custom notif sounds feature. This will be a copy paste from the PR (matrix-org/matrix-react-sdk#2928). Currently the feature is in review.
Issues:
Sounds are NOT preloaded, so the first usage of a notification sound is the first time it is loaded which may lead to delays.
This might not be too bad, and could be a feature in terms of not loading all your 1k sound at startup. However may piss off people on bad internet connections as sounds will come in seconds late. The solution may be to not play a sound if it loads too late. I feel like this will be a case of sticking the feature in as a labs thing to see if it's a problem in reality.
This uses a single url, so we can't multi-source for a single sound file.
Potentially problematic when shifting between browsers, and we could either look for what would be the most likely to be supported by all (ogg?), or create some (convoulted) UI for uploading them.
Using SettingsStore means using im.vector.* event types for storing settings and precludes being able to make this work cross protocol.
Use m.notification.sound instead as originally intended to prevent lock-in?
Each notification sound uses a new <audio> tag, which could quickly become bloaty
Could use a single audio and lots of AudioBuffers, but using a non-dom approach makes this a little harder to debug, and I don't think lots of invisible nodes causes any tangible problems.
Removing a sound from a room doesn't remove the tag.
An edge case, and iterating over all the rooms to check if any room is using them is a little complicated.
No way to "reuse" sounds from other rooms.
No way to change the default sound for the client, even though setting a default sound is supported.
At the request of the team, this is an epic to track the missing things from the custom notif sounds feature. This will be a copy paste from the PR (matrix-org/matrix-react-sdk#2928). Currently the feature is in review.
Issues:
SettingsStore
means usingim.vector.*
event types for storing settings and precludes being able to make this work cross protocol.m.notification.sound
instead as originally intended to prevent lock-in?<audio>
tag, which could quickly become bloatyAudioBuffers
, but using a non-dom approach makes this a little harder to debug, and I don't think lots of invisible nodes causes any tangible problems.The text was updated successfully, but these errors were encountered: