Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't create rooms if the /publicRooms API is broken #9046

Closed
ara4n opened this issue Mar 5, 2019 · 3 comments
Closed

Can't create rooms if the /publicRooms API is broken #9046

ara4n opened this issue Mar 5, 2019 · 3 comments
Assignees
@jryans
Labels
A-Room-Directory A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 5, 2019

Because we hide room creation in the room dir now, if the roomdir can't load because /publicRooms is slow/broken (as is often the case), you can't create rooms any more :(
@lampholder lampholder added T-Defect ui/ux P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Release-Blocker A-Room-List A-Room-Directory labels Mar 14, 2019
@jryans jryans self-assigned this Mar 27, 2019
@jryans
Copy link
Collaborator

jryans commented Mar 27, 2019

Do you have more detailed steps to reproduce here? I tried to force the problem by making the code path that requests /publicRooms never return, but I was still able create a room.

I don't think this needs to block the upcoming release as it stands (since we've had this UX live for a while with the redesign).

@jryans jryans removed their assignment Mar 27, 2019
@dbkr
Copy link
Member

dbkr commented Mar 27, 2019

If I block https://matrix.org/_matrix/client/r0/publicRooms in Network in chrome dev tools, this happens:

infiniteerrors

@jryans jryans self-assigned this Mar 27, 2019
@jryans
Copy link
Collaborator

jryans commented Mar 27, 2019

Ah right, if I simulate /publicRooms being rejected, I get something similar. Let's assume that's the issue we want to fix here.

jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 27, 2019
@jryans
Reorganise room directory code so new room is always available
0466e0a 
This reorganises the room directory so that the new room buttons is always
available no matter what state the overall directory is in.

Part of element-hq/element-web#9046
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 27, 2019
@jryans
Change loading errors in room directory to inline instead of modala
aca64f6 
This changes errors that may occur when loading the room directory so that the
message appears inline with the overall directory UI instead of in a new modal.
This is important so that the new room button remains on screen even if the
directory is down.

Fixes element-hq/element-web#9046
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Mar 27, 2019
@jryans
Change loading errors in room directory to inline instead of modal
055f833 
This changes errors that may occur when loading the room directory so that the
message appears inline with the overall directory UI instead of in a new modal.
This is important so that the new room button remains on screen even if the
directory is down.

Fixes element-hq/element-web#9046
@jryans jryans mentioned this issue Mar 27, 2019
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Room-Directory A-Room-List P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jryans @dbkr @ara4n @lampholder