Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed characters error on registration is unhelpful #8839

Closed
turt2live opened this issue Feb 20, 2019 · 2 comments
Closed

Allowed characters error on registration is unhelpful #8839

turt2live opened this issue Feb 20, 2019 · 2 comments
Assignees
@jryans
Labels
A-Authentication A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

image

(ignore the blue highlight - that's Chrome trying to be helpful)

This leaves me asking the question "what needs these characters?"

Steps to reproduce:

  1. Press register without entering anything
@jryans jryans added T-Defect P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Registration defect labels Feb 21, 2019
@jryans
Copy link
Collaborator

jryans commented Feb 21, 2019

Thanks for the report. This is related to the "quick wins" on validation that removed the "shaking" on field error. Now it's not clear which field has the validation error, so maybe the best fix it update the text for now. (Eventually, we hope to have validation tooltips pointing at the field.)

@bwindels bwindels mentioned this issue Feb 21, 2019
Closed
41 tasks
@jryans jryans self-assigned this Feb 21, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 21, 2019
@jryans
Clarify what the username error refers to
b741071 
Fixes element-hq/element-web#8839
@jryans jryans mentioned this issue Feb 21, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

Fixed in matrix-org/matrix-react-sdk#2673

@jryans jryans closed this as completed Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @lampholder