Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room settings should be named room settings #8329

Closed
turt2live opened this issue Jan 30, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2549
Closed

Room settings should be named room settings #8329

turt2live opened this issue Jan 30, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#2549
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

currently it is named "settings"
@turt2live turt2live mentioned this issue Jan 30, 2019
Closed
40 tasks
@lampholder lampholder added T-Defect P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jan 31, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jan 31, 2019
@turt2live
Fixed settings dialog header; Adjust padding on dialog
4036e52 
Some recent changes to dialogs changed how this works and altered the look of the settings dialogs. This fixes that and makes it so that the header and content scroll independently.

Fixes element-hq/element-web#8329
Fixes element-hq/element-web#8328
@turt2live turt2live mentioned this issue Jan 31, 2019
Merged
@turt2live
Copy link
Member Author

Fixed by matrix-org/matrix-react-sdk#2549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed settings dialog header; Adjust padding on dialog matrix-org/matrix-react-sdk
2 participants
@turt2live @lampholder