Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room v3 permalinks don't always work #8315

Closed
turt2live opened this issue Jan 30, 2019 · 2 comments
Closed

Room v3 permalinks don't always work #8315

turt2live opened this issue Jan 30, 2019 · 2 comments
Assignees
@turt2live
Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
Room upgrade bug ...

Comments

@turt2live
Copy link
Member

Sample:
https://matrix.to/#/!bxACizmWIbCVfYUUZD:jki.re/$39w4321vgLY9rzStEo3uvKXeHXq52qOqVV/ymH2lkZI?via=jki.re&via=t2l.io

Result:
image

My bet it on the slashes.
@lampholder
Copy link
Member

Is this a riot thing or a synapse thing?

@lampholder lampholder added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 30, 2019
@turt2live
Copy link
Member Author

Riot+Spec probably.

@lampholder lampholder removed the X-Needs-Info This issue is blocked awaiting information from the reporter label Jan 31, 2019
@turt2live turt2live mentioned this issue Feb 8, 2019
Closed
2 tasks
@manuroe manuroe mentioned this issue Feb 20, 2019
Open
@turt2live turt2live self-assigned this Mar 25, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 26, 2019
@turt2live
Handle all the segments of a v3 event ID
d8edf2e 
They may contain slashes, so it is not suitable to just pull the first segment after the room ID. Instead, we just recompile the event ID from known source, assuming everything afterwards is an event ID.

Fixes element-hq/element-web#8315

This will need adapting to support element-hq/element-web#9149
@turt2live turt2live mentioned this issue Mar 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Room-Upgrades P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
Room upgrade bug hunt: 1.0 Edition
Development

No branches or pull requests
2 participants
@turt2live @lampholder