Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot fails to start up if it can't contact the HS at load time #7455

Closed
fladd opened this issue Oct 4, 2018 · 4 comments
Closed

Riot fails to start up if it can't contact the HS at load time #7455

fladd opened this issue Oct 4, 2018 · 4 comments
Assignees
@dbkr
Labels
A-Lazy-Loading P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Milestone
RW015

Comments

@fladd
Copy link

fladd commented Oct 4, 2018

Description

When opening Riot (develop), I get the following error message:

image

Steps to reproduce

Describe how what happens differs from what you expected.

I expect to be able to use Riot.

Log: sent/not sent? yes

Version information

  • Platform: web (in-browser) or desktop? web

For the web app:

  • Browser: Chrome, Safari, Firefox? which version? Firefox 62.0.2 (64-bit)
  • OS: Windows, macOS, Ubuntu, Arch Linux, etc? Windows 10
  • URL: riot.im/develop

For the desktop app:

  • OS: Windows, macOS, Ubuntu, Arch Linux, etc?
  • Version: 0.x.y
@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Oct 5, 2018
@dbkr
Copy link
Member

dbkr commented Oct 5, 2018

Looks like this is a regression where the app fails to load if it can't contact the HS at startup time: we now check for lazy loading support on the server at startup and if this fails, the app fails to load.

@dbkr dbkr changed the title "Unable to restore session" Riot fails to start up if it can't contact the HS at load time Oct 5, 2018
@bwindels
Copy link
Contributor

bwindels commented Oct 5, 2018

Thinking about how to fix this. We need to check server support before the initial sync, because sync needs to be called with the correct filter. I see two options:

  • if off-line, you must already have a persisted session for anything meaningful to be shown. Hence we assume the same LL setting as the session used previously. This will fail to detect the server starting/stopping to support LL in the mean time once connected to the HS again.
  • instead of polling /sync, we poll /versions if the lazyLoadMembers was passed to the js-sdk. Feels like a bigger chance.

@kirushik
Copy link

kirushik commented Oct 7, 2018 •
edited
Loading

I'm encountering this issue (or something which looks exactly the same) on packaged riot-web for Ubuntu, latest version 0.16.5 installed from the official repo https://riot.im/packages/debian/.

Clicking "Clear Storage and Sign Out" doesn't help: after logging in with the dialog on the next start I'm presented the spinner which never finishes. After shutting down that forever-logging-in Riot and starting it again — this "Clear Storage and Sign Out" dialog shows up again.

I'll be glad to provide any necessary logs and debug info. So far it is not possible to use Riot on my machine.

@gerroon
Copy link

gerroon commented Oct 8, 2018 •
edited
Loading

I have this issue with the Riot's own web app, this happened after when I wanted to try the develop version, and since then I am unable to login with the release or the develop version.

@lampholder lampholder added this to the RW015 milestone Oct 9, 2018
dbkr added a commit to matrix-org/matrix-js-sdk that referenced this issue Oct 10, 2018
@dbkr
Don't fail to start up if lazy load check fails
3036209 
Do the lazy loading check in the batch of things we do before
starting a sync rather than at client start time, so we don't fail
to start the client if we can't hit the HS to determine LL support.

Fixes element-hq/element-web#7455
@dbkr dbkr mentioned this issue Oct 10, 2018
Merged
krombel pushed a commit to krombel/matrix-js-sdk that referenced this issue Nov 6, 2018
@dbkr @krombel
Don't fail to start up if lazy load check fails
d7e076b 
Do the lazy loading check in the batch of things we do before
starting a sync rather than at client start time, so we don't fail
to start the client if we can't hit the HS to determine LL support.

Fixes element-hq/element-web#7455
@bwindels bwindels mentioned this issue Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbkr dbkr

Labels
A-Lazy-Loading P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
RW015
Development

No branches or pull requests
6 participants
@kirushik @bwindels @dbkr @lampholder @fladd @gerroon