Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping an icon in the LLP while filtering causes the filter to be cleared #6253

Closed
turt2live opened this issue Feb 26, 2018 · 4 comments
Closed

Dropping an icon in the LLP while filtering causes the filter to be cleared #6253

turt2live opened this issue Feb 26, 2018 · 4 comments
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@turt2live
Copy link
Member

Description

  1. Click a group to filter on it
  2. Move any group in the LLP

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 64
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder lampholder added T-Defect ui/ux P1 S-Minor Impairs non-critical functionality or suitable workarounds exist labels Feb 28, 2018
@lampholder
Copy link
Member

So it does! That's annoying.

@lukebarnard1 if this is trivial to fix whilst we're in the area lets consider it for 0.14; I think if you're not expecting to touch that code again before 0.14 maybe lets leave it until (soon) after.

@lukebarnard1
Copy link
Contributor

I reckon this is the same thing causing #6156 which is in-turn caused by atlassian/react-beautiful-dnd#273 and fixed by atlassian/react-beautiful-dnd#353, but this hasn't been released.

@turt2live
Copy link
Member Author

Probably. Is the entire LLP background supposed to clear the filter, or just the X at the top? Currently it seems to still be the entire thing

@lukebarnard1
Copy link
Contributor

The intention is that the background also clears the filter.

lukebarnard1 added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 28, 2018
@lukebarnard1
Workaround for atlassian/react-beautiful-dnd#273
5c6c799 
Fix two bugs in Riot due to a single bug in react-b-dnd

Fixes element-hq/element-web#6253
Fixes element-hq/element-web#6156
@lukebarnard1 lukebarnard1 mentioned this issue Feb 28, 2018
Merged
lukebarnard1 added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 1, 2018
@lukebarnard1
Workaround for atlassian/react-beautiful-dnd#273
64332b3 
Fix two bugs in Riot due to a single bug in react-b-dnd

Fixes element-hq/element-web#6253
Fixes element-hq/element-web#6156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@turt2live @lampholder @lukebarnard1