Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We ignore m.call.answer events seemingly and display inbound call notifs for answered calls #344

Closed
matrixbot opened this issue Nov 8, 2015 · 1 comment
Closed

We ignore m.call.answer events seemingly and display inbound call notifs for answered calls #344

matrixbot opened this issue Nov 8, 2015 · 1 comment
Assignees
@kegsay
Labels
P2 T-Defect
Milestone
v0 - Friendly Beta

Comments

@matrixbot
Copy link

Created by @ matthew:matrix.org.

We ignore m.call.invites if we've seen an m.call.hangup, but not if we've seen an m.call.answer seemingly. This results in stale inbound call notifs
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@ara4n ara4n modified the milestones: v0, Ragnarok Dec 13, 2015
@kegsay kegsay self-assigned this Dec 14, 2015
kegsay added a commit to matrix-org/matrix-js-sdk that referenced this issue Dec 15, 2015
@kegsay
Do not erroneously emit Call.incoming events on startup
406a2bb 
Check to see if the call was answered or hung up in addition to having a valid
lifetime before emitting the event. Fixes element-hq/element-web#344
@kegsay kegsay mentioned this issue Dec 15, 2015
Merged
@kegsay
Copy link
Contributor

kegsay commented Dec 15, 2015

Exacerbated in v2 because the initial /sync is now processed chronologically due to matrix-org/matrix-js-sdk@6af2197 which means hangups would also be triggering this behaviour, not just answers.

@kegsay kegsay closed this as completed Dec 15, 2015
@babolivier babolivier mentioned this issue May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kegsay kegsay

Labels
P2 T-Defect
Projects
None yet
Milestone
v0 - Friendly Beta
Development

No branches or pull requests
3 participants
@ara4n @kegsay @matrixbot