Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnknownDeviceDialog box breaks VoIP in E2E rooms #3285

Closed
ara4n opened this issue Feb 21, 2017 · 5 comments
Closed

UnknownDeviceDialog box breaks VoIP in E2E rooms #3285

ara4n opened this issue Feb 21, 2017 · 5 comments
Assignees
@lukebarnard1
Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 21, 2017

The VoIP call silently fails rather than coughing up the dialog box.
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

See also #2669

@ara4n ara4n added T-Defect X-Cannot-Reproduce S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-E2EE P1 and removed X-Cannot-Reproduce labels Feb 21, 2017
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

see also #3124

@ara4n ara4n mentioned this issue Feb 21, 2017
Closed
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

it's also a problem for the person receiving the call (where the call then rings forever etc)

@ara4n ara4n mentioned this issue Feb 21, 2017
Closed
@lukebarnard1 lukebarnard1 mentioned this issue Feb 22, 2017
Merged
@ara4n
Copy link
Member Author

ara4n commented Mar 14, 2017

Are we sure this is fixed? It feels to me that the UDD is showing up a long time you try to hit 'Answer', and then appears multiple times, even if you say "Send anyway"?

@ara4n ara4n reopened this Mar 14, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 15, 2017 •
edited
Loading

@ara4n I wonder if more than one event is being sent at once, triggering 3 UDEs and 3 consecutive UDDs... Yep I've confirmed this. I'm too sure how the signalling works so I'm not sure why this would happen, but I've confirmed that 3 UDEs occur when starting a call.

So I think we need to de-dupe dispatches for the UDD, only ever showing one. This is OK because send anyway sends all unsent events. It might be a good idea to show which events are unsent in the dialog somehow.

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 16, 2017
Fix UDD for voip in e2e rooms
3ce0da4 
When starting a call, several events are sent and if some devices are unverified, all three will trigger their own UnknownDeviceError. This causes three overlapping, identical UnknownDeviceDialogs.

This change effectively dedupes the dialogs so that only one is shown. This is safe to do because the UDD allows resending of _all_ events that were left unsent.

Fixes element-hq/element-web#3285
@lukebarnard1 lukebarnard1 mentioned this issue Mar 16, 2017
Merged
@t3chguy t3chguy mentioned this issue Aug 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
A-E2EE P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @lukebarnard1