Properly generate mentions when editing a reply with MSC3952 #24924
Assignees
Comments
Merged
3 tasks
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this issue
Apr 21, 2023
* Ship linux tarball with static sqlcipher ([\element-hq#597](element-hq#597)). Fixes element-hq/element-web#18486. * Show recent room breadcrumbs on touchbar ([\element-hq#183](element-hq#183)). Fixes element-hq/element-web#15998. * Clear electron data when logging out ([\element-hq#578](element-hq#578)). * Send Electron crashpad reports to Sentry from Nightly ([\element-hq#579](element-hq#579)). Fixes element-hq/element-web#18263. * Recommend element-io-archive-keyring from our Debian package ([\element-hq#566](element-hq#566)). * Allow desktop app to expose recent rooms in UI integrations ([\#16940](element-hq/element-web#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\#24820](element-hq/element-web#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq/element-web#10559. * Mentions as links rte ([\#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq/element-web#24751 and element-hq/element-web#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq/element-web#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq/element-web#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq/element-web#24825. * Poll history - access poll history from room settings ([\#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. * Run build_linux in docker using an older glibc ([\element-hq#599](element-hq#599)). Fixes element-hq/element-web#24981. * Use a newly generated access_token while joining Jitsi ([\#24646](element-hq/element-web#24646)). Fixes element-hq/element-web#24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\#24777](element-hq/element-web#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq/element-web#24995. * Properly generate mentions when editing a reply with MSC3952 ([\#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq/element-web#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq/element-web#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq/element-web#24921. * Fix decryption failure bar covering the timeline ([\#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq/element-web#24780 element-hq/element-web#24074 and element-hq/element-web#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq/element-web#24919. * Handle group call redaction ([\#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq/element-web#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq/element-web#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq/element-web#24959. * Fix "show read receipts sent by other users" not applying to threads ([\#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq/element-web#24910. * Fix joining public rooms without aliases in search dialog ([\#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq/element-web#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq/element-web#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq/element-web#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq/element-web#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq/element-web#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq/element-web#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq/element-web#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq/element-web#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq/element-web#24397. * Fix `[object Object]` in feedback metadata ([\#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq/element-web#24615. * Fix import e2e key dialog staying disabled after paste ([\#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq/element-web#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq/element-web#24813. * Fix UIFeature.Registration not applying to all paths ([\#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq/element-web#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq/element-web#24797. * Fix start DM with pending third party invite ([\#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq/element-web#24781. * Fix long display name overflowing reply tile on IRC layout ([\#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq/element-web#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq/element-web#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\#10308](matrix-org/matrix-react-sdk#10308)).
su-ex
added a commit
to SchildiChat/element-web
that referenced
this issue
Apr 21, 2023
* Allow desktop app to expose recent rooms in UI integrations ([\element-hq#16940](element-hq#16940)). * Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#24820](element-hq#24820)). Contributed by @dhenneke. * Style mentions as pills in rich text editor ([\element-hq#10448](matrix-org/matrix-react-sdk#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\element-hq#10364](matrix-org/matrix-react-sdk#10364)). Contributed by @maheichyk. * Mentions as links rte ([\element-hq#10463](matrix-org/matrix-react-sdk#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\element-hq#10405](matrix-org/matrix-react-sdk#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\element-hq#10363](matrix-org/matrix-react-sdk#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\element-hq#10425](matrix-org/matrix-react-sdk#10425)). Fixes element-hq#10559. * Mentions as links rte ([\element-hq#10422](matrix-org/matrix-react-sdk#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\element-hq#9983](matrix-org/matrix-react-sdk#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\element-hq#10269](matrix-org/matrix-react-sdk#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\element-hq#10392](matrix-org/matrix-react-sdk#10392)). Fixes element-hq#24751 and element-hq#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\element-hq#10381](matrix-org/matrix-react-sdk#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\element-hq#6084](matrix-org/matrix-react-sdk#6084)). Fixes element-hq#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\element-hq#10380](matrix-org/matrix-react-sdk#10380)). Fixes element-hq#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\element-hq#10388](matrix-org/matrix-react-sdk#10388)). Fixes element-hq#24825. * Poll history - access poll history from room settings ([\element-hq#10356](matrix-org/matrix-react-sdk#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\element-hq#10376](matrix-org/matrix-react-sdk#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\#10288](matrix-org/matrix-react-sdk#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\element-hq#10348](matrix-org/matrix-react-sdk#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\element-hq#10346](matrix-org/matrix-react-sdk#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\element-hq#10339](matrix-org/matrix-react-sdk#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\element-hq#10344](matrix-org/matrix-react-sdk#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\element-hq#10341](matrix-org/matrix-react-sdk#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\element-hq#10342](matrix-org/matrix-react-sdk#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\#10340](matrix-org/matrix-react-sdk#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\element-hq#10338](matrix-org/matrix-react-sdk#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\element-hq#10326](matrix-org/matrix-react-sdk#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\element-hq#10332](matrix-org/matrix-react-sdk#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\element-hq#10287](matrix-org/matrix-react-sdk#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\element-hq#10295](matrix-org/matrix-react-sdk#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\element-hq#10320](matrix-org/matrix-react-sdk#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\#10297](matrix-org/matrix-react-sdk#10297)). Contributed by @andybalaam. * Use a newly generated access_token while joining Jitsi ([\element-hq#24646](element-hq#24646)). Fixes element-hq#24687. Contributed by @emrahcom. * Fix cloudflare action pointing at commit hash instead of tag ([\element-hq#24777](element-hq#24777)). Contributed by @justjanne. * Allow editing with RTE to overflow for autocomplete visibility ([\element-hq#10499](matrix-org/matrix-react-sdk#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\element-hq#10479](matrix-org/matrix-react-sdk#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\#10487](matrix-org/matrix-react-sdk#10487)). Fixes element-hq#24995. * Properly generate mentions when editing a reply with MSC3952 ([\element-hq#10486](matrix-org/matrix-react-sdk#10486)). Fixes element-hq#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\#10131](matrix-org/matrix-react-sdk#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\element-hq#10419](matrix-org/matrix-react-sdk#10419)). Fixes element-hq#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\element-hq#10476](matrix-org/matrix-react-sdk#10476)). Fixes element-hq#24921. * Fix decryption failure bar covering the timeline ([\element-hq#10360](matrix-org/matrix-react-sdk#10360)). Fixes element-hq#24780 element-hq#24074 and element-hq#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\element-hq#10470](matrix-org/matrix-react-sdk#10470)). Fixes element-hq#24919. * Handle group call redaction ([\element-hq#10465](matrix-org/matrix-react-sdk#10465)). * Display relative timestamp for threads on the same calendar day ([\#10399](matrix-org/matrix-react-sdk#10399)). Fixes element-hq#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\element-hq#10424](matrix-org/matrix-react-sdk#10424)). Fixes element-hq#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\element-hq#10457](matrix-org/matrix-react-sdk#10457)). Fixes element-hq#24959. * Fix "show read receipts sent by other users" not applying to threads ([\element-hq#10445](matrix-org/matrix-react-sdk#10445)). Fixes element-hq#24910. * Fix joining public rooms without aliases in search dialog ([\element-hq#10437](matrix-org/matrix-react-sdk#10437)). Fixes element-hq#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\element-hq#10436](matrix-org/matrix-react-sdk#10436)). Fixes element-hq#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\element-hq#10211](matrix-org/matrix-react-sdk#10211)). Fixes element-hq#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\element-hq#10423](matrix-org/matrix-react-sdk#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\element-hq#10412](matrix-org/matrix-react-sdk#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\element-hq#10396](matrix-org/matrix-react-sdk#10396)). Fixes element-hq#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\#10188](matrix-org/matrix-react-sdk#10188)). Fixes element-hq#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\element-hq#10402](matrix-org/matrix-react-sdk#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\element-hq#10404](matrix-org/matrix-react-sdk#10404)). Fixes element-hq#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\element-hq#10257](matrix-org/matrix-react-sdk#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\element-hq#10280](matrix-org/matrix-react-sdk#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\element-hq#10353](matrix-org/matrix-react-sdk#10353)). Fixes element-hq#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\element-hq#10373](matrix-org/matrix-react-sdk#10373)). Fixes element-hq#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\element-hq#10394](matrix-org/matrix-react-sdk#10394)). Fixes element-hq#24397. * Fix `[object Object]` in feedback metadata ([\element-hq#10390](matrix-org/matrix-react-sdk#10390)). * Fix pinned messages card saying nothing pinned while loading ([\#10385](matrix-org/matrix-react-sdk#10385)). Fixes element-hq#24615. * Fix import e2e key dialog staying disabled after paste ([\element-hq#10375](matrix-org/matrix-react-sdk#10375)). Fixes element-hq#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\element-hq#10369](matrix-org/matrix-react-sdk#10369)). Fixes element-hq#24813. * Fix UIFeature.Registration not applying to all paths ([\element-hq#10371](matrix-org/matrix-react-sdk#10371)). Fixes element-hq#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\element-hq#10359](matrix-org/matrix-react-sdk#10359)). Fixes element-hq#24797. * Fix start DM with pending third party invite ([\element-hq#10347](matrix-org/matrix-react-sdk#10347)). Fixes element-hq#24781. * Fix long display name overflowing reply tile on IRC layout ([\element-hq#10343](matrix-org/matrix-react-sdk#10343)). Fixes element-hq#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\element-hq#9016](matrix-org/matrix-react-sdk#9016)). Fixes element-hq#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\element-hq#10279](matrix-org/matrix-react-sdk#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\element-hq#10308](matrix-org/matrix-react-sdk#10308)).
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this issue
Apr 21, 2023
* Style mentions as pills in rich text editor ([\matrix-org#10448](matrix-org#10448)). Contributed by @alunturner. * Show room create icon if "UIComponent.roomCreation" is enabled ([\matrix-org#10364](matrix-org#10364)). Contributed by @maheichyk. * Mentions as links rte ([\matrix-org#10463](matrix-org#10463)). Contributed by @alunturner. * Better error handling in jump to date ([\matrix-org#10405](matrix-org#10405)). Contributed by @MadLittleMods. * Show "Invite" menu option if "UIComponent.sendInvites" is enabled. ([\matrix-org#10363](matrix-org#10363)). Contributed by @maheichyk. * Added `UserProfilesStore`, `LruCache` and user permalink profile caching ([\matrix-org#10425](matrix-org#10425)). Fixes element-hq/element-web#10559. * Mentions as links rte ([\matrix-org#10422](matrix-org#10422)). Contributed by @alunturner. * Implement MSC3952: intentional mentions ([\matrix-org#9983](matrix-org#9983)). * Implement MSC3973: Search users in the user directory with the Widget API ([\matrix-org#10269](matrix-org#10269)). Contributed by @dhenneke. * Permalinks to message are now displayed as pills ([\matrix-org#10392](matrix-org#10392)). Fixes element-hq/element-web#24751 and element-hq/element-web#24706. * Show search,dial,explore in filterContainer if "UIComponent.filterContainer" is enabled ([\matrix-org#10381](matrix-org#10381)). Contributed by @maheichyk. * Increase space panel collapse clickable area ([\matrix-org#6084](matrix-org#6084)). Fixes element-hq/element-web#17379. Contributed by @jaiwanth-v. * Add fallback for replies to Polls ([\matrix-org#10380](matrix-org#10380)). Fixes element-hq/element-web#24197. Contributed by @kerryarchibald. * Permalinks to rooms and users are now pillified ([\matrix-org#10388](matrix-org#10388)). Fixes element-hq/element-web#24825. * Poll history - access poll history from room settings ([\matrix-org#10356](matrix-org#10356)). Contributed by @kerryarchibald. * Add API params to mute audio and/or video in Jitsi calls by default ([\matrix-org#10376](matrix-org#10376)). Contributed by @dhenneke. * Notifications: inline error message on notifications saving error ([\matrix-org#10288](matrix-org#10288)). Contributed by @kerryarchibald. * Support dynamic room predecessor in SpaceProvider ([\matrix-org#10348](matrix-org#10348)). Contributed by @andybalaam. * Support dynamic room predecessors for RoomProvider ([\matrix-org#10346](matrix-org#10346)). Contributed by @andybalaam. * Support dynamic room predecessors in OwnBeaconStore ([\matrix-org#10339](matrix-org#10339)). Contributed by @andybalaam. * Support dynamic room predecessors in ForwardDialog ([\matrix-org#10344](matrix-org#10344)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceHierarchy ([\matrix-org#10341](matrix-org#10341)). Contributed by @andybalaam. * Support dynamic room predecessors in AddExistingToSpaceDialog ([\matrix-org#10342](matrix-org#10342)). Contributed by @andybalaam. * Support dynamic room predecessors in leave-behaviour ([\matrix-org#10340](matrix-org#10340)). Contributed by @andybalaam. * Support dynamic room predecessors in StopGapWidgetDriver ([\matrix-org#10338](matrix-org#10338)). Contributed by @andybalaam. * Support dynamic room predecessors in WidgetLayoutStore ([\matrix-org#10326](matrix-org#10326)). Contributed by @andybalaam. * Support dynamic room predecessors in SpaceStore ([\matrix-org#10332](matrix-org#10332)). Contributed by @andybalaam. * Sync polls push rules on changes to account_data ([\matrix-org#10287](matrix-org#10287)). Contributed by @kerryarchibald. * Support dynamic room predecessors in BreadcrumbsStore ([\matrix-org#10295](matrix-org#10295)). Contributed by @andybalaam. * Improved a11y for Field feedback and Secure Phrase input ([\matrix-org#10320](matrix-org#10320)). Contributed by @Sebbones. * Support dynamic room predecessors in RoomNotificationStateStore ([\matrix-org#10297](matrix-org#10297)). Contributed by @andybalaam. * Allow editing with RTE to overflow for autocomplete visibility ([\matrix-org#10499](matrix-org#10499)). Contributed by @alunturner. * Added auto focus to Github URL on opening of debug logs modal ([\matrix-org#10479](matrix-org#10479)). Contributed by @ShivamSpm. * Fix detection of encryption for all users in a room ([\matrix-org#10487](matrix-org#10487)). Fixes element-hq/element-web#24995. * Properly generate mentions when editing a reply with MSC3952 ([\matrix-org#10486](matrix-org#10486)). Fixes element-hq/element-web#24924. Contributed by @kerryarchibald. * Improve performance of rendering a room with many hidden events ([\matrix-org#10131](matrix-org#10131)). Contributed by @andybalaam. * Prevent future date selection in jump to date ([\matrix-org#10419](matrix-org#10419)). Fixes element-hq/element-web#20800. Contributed by @MadLittleMods. * Add aria labels to message search bar to improve accessibility ([\matrix-org#10476](matrix-org#10476)). Fixes element-hq/element-web#24921. * Fix decryption failure bar covering the timeline ([\matrix-org#10360](matrix-org#10360)). Fixes element-hq/element-web#24780 element-hq/element-web#24074 and element-hq/element-web#24183. Contributed by @luixxiul. * Improve profile picture settings accessibility ([\matrix-org#10470](matrix-org#10470)). Fixes element-hq/element-web#24919. * Handle group call redaction ([\matrix-org#10465](matrix-org#10465)). * Display relative timestamp for threads on the same calendar day ([\matrix-org#10399](matrix-org#10399)). Fixes element-hq/element-web#24841. Contributed by @kerryarchibald. * Fix timeline list and paragraph display issues ([\matrix-org#10424](matrix-org#10424)). Fixes element-hq/element-web#24602. Contributed by @alunturner. * Use unique keys for voice broadcast pips ([\matrix-org#10457](matrix-org#10457)). Fixes element-hq/element-web#24959. * Fix "show read receipts sent by other users" not applying to threads ([\matrix-org#10445](matrix-org#10445)). Fixes element-hq/element-web#24910. * Fix joining public rooms without aliases in search dialog ([\matrix-org#10437](matrix-org#10437)). Fixes element-hq/element-web#23937. * Add input validation for `m.direct` in `DMRoomMap` ([\matrix-org#10436](matrix-org#10436)). Fixes element-hq/element-web#24909. * Reduce height reserved for "collapse" button's line on IRC layout ([\matrix-org#10211](matrix-org#10211)). Fixes element-hq/element-web#24605. Contributed by @luixxiul. * Fix `creatorUserId is required` error when opening sticker picker ([\matrix-org#10423](matrix-org#10423)). * Fix block/inline Element descendants error noise in `NewRoomIntro.tsx` ([\matrix-org#10412](matrix-org#10412)). Contributed by @MadLittleMods. * Fix profile resizer to make first character of a line selectable in IRC layout ([\matrix-org#10396](matrix-org#10396)). Fixes element-hq/element-web#14764. Contributed by @luixxiul. * Ensure space between wrapped lines of room name on IRC layout ([\matrix-org#10188](matrix-org#10188)). Fixes element-hq/element-web#24742. Contributed by @luixxiul. * Remove unreadable alt attribute from the room status bar warning icon (nonsense to screenreaders) ([\matrix-org#10402](matrix-org#10402)). Contributed by @MadLittleMods. * Fix big date separators when jump to date is enabled ([\matrix-org#10404](matrix-org#10404)). Fixes element-hq/element-web#22969. Contributed by @MadLittleMods. * Fixes user authentication when registering via the module API ([\matrix-org#10257](matrix-org#10257)). Contributed by @maheichyk. * Handle more edge cases in Space Hierarchy ([\matrix-org#10280](matrix-org#10280)). Contributed by @justjanne. * Further improve performance with lots of hidden events ([\matrix-org#10353](matrix-org#10353)). Fixes element-hq/element-web#24480. Contributed by @andybalaam. * Respect user cancelling upload flow by dismissing spinner ([\matrix-org#10373](matrix-org#10373)). Fixes element-hq/element-web#24667. * When starting a DM, the end-to-end encryption status icon does now only appear if the DM can be encrypted ([\matrix-org#10394](matrix-org#10394)). Fixes element-hq/element-web#24397. * Fix `[object Object]` in feedback metadata ([\matrix-org#10390](matrix-org#10390)). * Fix pinned messages card saying nothing pinned while loading ([\matrix-org#10385](matrix-org#10385)). Fixes element-hq/element-web#24615. * Fix import e2e key dialog staying disabled after paste ([\matrix-org#10375](matrix-org#10375)). Fixes element-hq/element-web#24818. * Show all labs even if incompatible, with appropriate tooltip explaining requirements ([\matrix-org#10369](matrix-org#10369)). Fixes element-hq/element-web#24813. * Fix UIFeature.Registration not applying to all paths ([\matrix-org#10371](matrix-org#10371)). Fixes element-hq/element-web#24814. * Clicking on a user pill does now only open the profile in the right panel and no longer navigates to the home view. ([\matrix-org#10359](matrix-org#10359)). Fixes element-hq/element-web#24797. * Fix start DM with pending third party invite ([\matrix-org#10347](matrix-org#10347)). Fixes element-hq/element-web#24781. * Fix long display name overflowing reply tile on IRC layout ([\matrix-org#10343](matrix-org#10343)). Fixes element-hq/element-web#24738. Contributed by @luixxiul. * Display redacted body on ThreadView in the same way as normal messages ([\matrix-org#9016](matrix-org#9016)). Fixes element-hq/element-web#24729. Contributed by @luixxiul. * Handle more edge cases in ACL updates ([\matrix-org#10279](matrix-org#10279)). Contributed by @justjanne. * Allow parsing png files to fail if thumbnailing is successful ([\matrix-org#10308](matrix-org#10308)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #24377 initial support for MSC3952 was implemented in #9983. That implementation has a couple of bugs/deficiencies to fix-up around editing messages. (The below all assume you have MSC3952 support enabled.)
MSC3952 states that clients may wish to include the user being replied to in the mentions array; this is handled properly for normal messages, content messages, voice messages, and command messages. It is not handled properly when editing a message which is a reply. 1
The result of this is that the user being replied to gets dropped from the mentions array after the edit, which is incorrect. Note that the top-level mentions object only includes newly (in that edit) mentioned people (which the replied person will not be), but the one under
m.new_contentshould include all the users being replied to.I think all that is necessary is fetching the replied-to
MatrixEventand passing it intoattachMentions, but it might need further testing.Footnotes
As an aside it looks like the editing code also double-checks the
SettingsStoreto ensure intentional mentions are enabled. This was probably left-over from refactoring and we should remove it when updating this logic to properly handle replies. ↩The text was updated successfully, but these errors were encountered: