Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Room header thread unread icon stuck #23590

Closed
germain-gg opened this issue Oct 25, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2804
Closed

Room header thread unread icon stuck #23590

germain-gg opened this issue Oct 25, 2022 · 0 comments · Fixed by matrix-org/matrix-js-sdk#2804
Assignees
Labels
A-Notifications A-Room-View A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. reset unread thread notificaiton
  2. notice that it's stuck

We need to dispatch an event when notifications are reset, otherwise we do not know when there's no notif left

Outcome

What did you expect?

for the unread icon to disappear

What happened instead?

it stayed

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@germain-gg germain-gg added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist A-Room-View A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely A-Threads Z-Labs labels Oct 25, 2022
@germain-gg germain-gg self-assigned this Oct 25, 2022
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Nov 12, 2022
* Loading threads with server-side assistance ([\matrix-org#2735](matrix-org#2735)). Contributed by @justjanne.
* Support sign in + E2EE set up using QR code implementing MSC3886, MSC3903 and MSC3906 ([\matrix-org#2747](matrix-org#2747)). Contributed by @hughns.
* Replace `instanceof Array` with `Array.isArray` ([\matrix-org#2812](matrix-org#2812)). Fixes matrix-org#2811.
* Emit UnreadNotification event on notifications reset ([\matrix-org#2804](matrix-org#2804)). Fixes element-hq/element-web#23590.
* Fix incorrect prevEv being sent in ClientEvent.AccountData events ([\matrix-org#2794](matrix-org#2794)).
* Fix build error caused by wrong ts-strict improvements ([\matrix-org#2783](matrix-org#2783)). Contributed by @justjanne.
* Encryption should not hinder verification ([\matrix-org#2734](matrix-org#2734)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Room-View A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant