Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in-app permalinks to non-pill rooms now take you to matrix.to rather than staying in-app #22874

Closed
ara4n opened this issue Jul 17, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9087
Closed

in-app permalinks to non-pill rooms now take you to matrix.to rather than staying in-app #22874

ara4n opened this issue Jul 17, 2022 · 2 comments · Fixed by matrix-org/matrix-react-sdk#9087
Assignees
@Johennes
Labels
A-Composer A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Jul 17, 2022

in element-web on desktop, type a room alias like #twim:matrix.org without tab completing it into a pill. click on the link, and it takes you to matrix.to rather than taking you within the app straight to the room
@germain-gg germain-gg added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Composer A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely labels Jul 18, 2022
@turt2live turt2live self-assigned this Jul 18, 2022
@turt2live
Copy link
Member

confirmed regression on staging, due to the work in matrix-org/matrix-react-sdk#8394

Likely a similar fix to matrix-org/matrix-react-sdk#8917, though this particular case seems non-trivial.

@turt2live turt2live removed their assignment Jul 18, 2022
Johennes added a commit to Johennes/matrix-react-sdk that referenced this issue Jul 21, 2022
@Johennes
Unbreak in-app permalink tooltips
359f5e0 
Fixes: element-hq/element-web#22874
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes mentioned this issue Jul 21, 2022
Merged
3 tasks
Johennes added a commit to Johennes/matrix-react-sdk that referenced this issue Jul 21, 2022
@Johennes
Unbreak in-app permalink tooltips
97339ad 
Fixes: element-hq/element-web#22874
Signed-off-by: Johannes Marbach <[email protected]>
@Johennes
Copy link
Contributor

Sorry for breaking this. I think / hope matrix-org/matrix-react-sdk#9087 should fix it. It had nothing to do with the span actually.

Also, since this was labeled a release blocker and I was assigned, please note that the regressing change was a spare time contribution so I'm handling this with my limited private life SLA.

Johennes added a commit to Johennes/matrix-react-sdk that referenced this issue Jul 26, 2022
@Johennes
Unbreak in-app permalink tooltips
62cabcc 
Fixes: element-hq/element-web#22874
Signed-off-by: Johannes Marbach <[email protected]>
t3chguy pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 26, 2022
@Johennes
Unbreak in-app permalink tooltips (#9087)
e28fd86 
* Unbreak in-app permalink tooltips

Fixes: element-hq/element-web#22874
Signed-off-by: Johannes Marbach <[email protected]>

* Appease the linter

* Fix the tests
t3chguy pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 26, 2022
@Johennes
Unbreak in-app permalink tooltips (#9100)
6719734 
* Unbreak in-app permalink tooltips

Fixes: element-hq/element-web#22874
Signed-off-by: Johannes Marbach <[email protected]>

* Appease the linter

* Fix the tests
su-ex added a commit to SchildiChat/element-desktop that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v1.11.2' into sc
2996b7b 
* Live location share -  focus on user location on list item click ([\#9051](matrix-org/matrix-react-sdk#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\#9071](matrix-org/matrix-react-sdk#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\#9097](matrix-org/matrix-react-sdk#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\#9004](matrix-org/matrix-react-sdk#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\#9086](matrix-org/matrix-react-sdk#9086)).
* Use "frequently used emojis" for autocompletion in composer ([\#8998](matrix-org/matrix-react-sdk#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\#9068](matrix-org/matrix-react-sdk#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\#9037](matrix-org/matrix-react-sdk#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\#8842](matrix-org/matrix-react-sdk#8842)).
* Implement Use Case Selection screen ([\#8984](matrix-org/matrix-react-sdk#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\#9047](matrix-org/matrix-react-sdk#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\#9031](matrix-org/matrix-react-sdk#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\#8907](matrix-org/matrix-react-sdk#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\#9088](matrix-org/matrix-react-sdk#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\#9087](matrix-org/matrix-react-sdk#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\#9095](matrix-org/matrix-react-sdk#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\#9058](matrix-org/matrix-react-sdk#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\#9075](matrix-org/matrix-react-sdk#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\#9062](matrix-org/matrix-react-sdk#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\#9063](matrix-org/matrix-react-sdk#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\#9055](matrix-org/matrix-react-sdk#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
su-ex added a commit to SchildiChat/matrix-react-sdk that referenced this issue Aug 22, 2022
@su-ex
Merge tag 'v3.51.0' into sc
8cb2754 
* Live location share -  focus on user location on list item click ([\matrix-org#9051](matrix-org#9051)). Contributed by @kerryarchibald.
* Live location sharing - don't trigger unread counts for beacon location events ([\matrix-org#9071](matrix-org#9071)). Contributed by @kerryarchibald.
* Support for sending voice messages as replies and in threads ([\matrix-org#9097](matrix-org#9097)). Fixes element-hq/element-web#22031.
* Add `Reply in thread` button to the right-click message context-menu ([\matrix-org#9004](matrix-org#9004)). Fixes element-hq/element-web#22745.
* Starred_Messages_Feature_Contd_II/Outreachy ([\matrix-org#9086](matrix-org#9086)).
*  Use "frequently used emojis" for autocompletion in composer ([\matrix-org#8998](matrix-org#8998)). Fixes element-hq/element-web#18978. Contributed by @grimhilt.
* Improve clickability of view source event toggle button  ([\matrix-org#9068](matrix-org#9068)). Fixes element-hq/element-web#21856. Contributed by @luixxiul.
* Improve clickability of "collapse" link button on bubble layout ([\matrix-org#9037](matrix-org#9037)). Fixes element-hq/element-web#22864. Contributed by @luixxiul.
* Starred_Messages_Feature/Outreachy ([\matrix-org#8842](matrix-org#8842)).
* Implement Use Case Selection screen ([\matrix-org#8984](matrix-org#8984)). Contributed by @justjanne.
* Live location share - handle insufficient permissions in location sharing ([\matrix-org#9047](matrix-org#9047)). Contributed by @kerryarchibald.
* Improve _FilePanel.scss ([\matrix-org#9031](matrix-org#9031)). Contributed by @luixxiul.
* Improve spotlight accessibility by adding context menus ([\matrix-org#8907](matrix-org#8907)). Fixes element-hq/element-web#20875 and element-hq/element-web#22675. Contributed by @justjanne.
* Replace mask-images with svg components in MessageActionBar ([\matrix-org#9088](matrix-org#9088)). Fixes element-hq/element-web#22912. Contributed by @kerryarchibald.
* Unbreak in-app permalink tooltips ([\matrix-org#9087](matrix-org#9087)). Fixes element-hq/element-web#22874.
* Show a back button when viewing a space member ([\matrix-org#9095](matrix-org#9095)). Fixes element-hq/element-web#22898.
* Align the right edge of info tile lines with normal ones on IRC layout ([\matrix-org#9058](matrix-org#9058)). Fixes element-hq/element-web#22871. Contributed by @luixxiul.
* Prevent email verification from overriding existing sessions ([\matrix-org#9075](matrix-org#9075)). Fixes element-hq/element-web#22881. Contributed by @justjanne.
* Fix wrong buttons being used when exploring public rooms ([\matrix-org#9062](matrix-org#9062)). Fixes element-hq/element-web#22862.
* Re-add padding to generic event list summary on IRC layout ([\matrix-org#9063](matrix-org#9063)). Fixes element-hq/element-web#22869. Contributed by @luixxiul.
* Joining federated rooms via the spotlight search should no longer cause a "No known servers" error. ([\matrix-org#9055](matrix-org#9055)). Fixes element-hq/element-web#22845. Contributed by @Half-Shot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Johennes Johennes

Labels
A-Composer A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unbreak in-app permalink tooltips Johennes/matrix-react-sdk
4 participants
@germain-gg @Johennes @turt2live @ara4n