Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to 2022021801 nightly has made most of my rooms vanish and/or corrupt #21130

Closed
ara4n opened this issue Feb 18, 2022 · 8 comments · Fixed by matrix-org/matrix-js-sdk#2187 or matrix-org/matrix-js-sdk#2207
Closed

Upgrading to 2022021801 nightly has made most of my rooms vanish and/or corrupt #21130

ara4n opened this issue Feb 18, 2022 · 8 comments · Fixed by matrix-org/matrix-js-sdk#2187 or matrix-org/matrix-js-sdk#2207
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Feb 18, 2022

Steps to reproduce

  1. Was running nightly prior to Feb 18 (probably a build from Feb 15 or so)
  2. Upgraded
  3. All my spaces disappeared, and most of my rooms, and remaining rooms seem to have lost state.

Outcome

What did you expect?

The application not to selfdestruct on upgrade

What happened instead?

The app selfdestructed on upgrade.

Operating system

macOS

Application version

nightly 2022021801

How did you install the app?

nightly

Homeserver

matrix.org

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Feb 18, 2022
@dbkr
Copy link
Member

dbkr commented Feb 18, 2022 

2022-02-18T18:19:38.331Z E Error processing cached sync TypeError: Cannot read properties of undefined (reading 'getId')
    at Room.createThread (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:30926:51)
    at Room.addThreadedEvent (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:30915:23)
    at async MatrixClient.processThreadEvents (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:50141:7)
    at async vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:72311:7
    at async Object.promiseMapSeries (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/bundle.js:1182:5)
    at async SyncApi.processSyncResponse (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:72235:5)
    at async SyncApi.syncFromCache (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:71800:7)
    at async SyncApi.recoverFromSyncStartupError (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:71500:5)
    at async getPushRules (vector://vector/webapp/bundles/5fb8ea8c2bb655aeece7/init.js:71580:9)

this is probably worth at least looking at before RC

@dbkr dbkr added S-Critical Prevents work, causes data loss and/or has no workaround X-Regression X-Release-Blocker labels Feb 18, 2022
@ara4n
Copy link
Member Author

ara4n commented Feb 18, 2022

(reloading the desktop app recovered as if nothing had happened)

@germain-gg germain-gg self-assigned this Feb 21, 2022
@germain-gg
Copy link
Contributor

Will take a look at that this morning

@germain-gg germain-gg mentioned this issue Feb 21, 2022
Merged
@ara4n
Copy link
Member Author

ara4n commented Feb 26, 2022

This just happened again.

@ara4n ara4n reopened this Feb 26, 2022
@t3chguy
Copy link
Member

t3chguy commented Feb 28, 2022 

2022-02-26T17:50:47.542Z E Error processing cached sync TypeError: Cannot read properties of undefined (reading 'localTimestamp')
    at Room.createThread (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:21312:84)
    at Room.addThreadedEvent (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:21282:23)
    at async MatrixClient.processThreadEvents (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:19432:7)
    at async vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:66237:7
    at async Object.promiseMapSeries (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/bundle.js:1182:5)
    at async SyncApi.processSyncResponse (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:66161:5)
    at async SyncApi.syncFromCache (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:65726:7)
    at async getFilter (vector://vector/webapp/bundles/5a49dfe6eced0bf94934/init.js:65622:7)

@germain-gg germain-gg mentioned this issue Feb 28, 2022
Merged
@ara4n
Copy link
Member Author

ara4n commented Mar 5, 2022

Just happened again on 2022030402

@ara4n ara4n reopened this Mar 5, 2022
@dbkr
Copy link
Member

dbkr commented Mar 8, 2022

It's starting up without net access and failing to set up encrypted rooms because it can't fetch the member list:

2022-03-05T15:17:09.808Z I Enabling encryption in !fQZDstnphEFtEhuPDt:matrix.org; starting to track device lists for all users therein
2022-03-05T15:17:09.808Z I Starting to track devices for room !fQZDstnphEFtEhuPDt:matrix.org ...
2022-03-05T15:17:09.815Z E request failed: CORS request rejected: https://matrix-client.matrix.org/_matrix/client/r0/rooms/!fQZDstnphEFtEhuPDt%3Amatrix.org/members?not_membership=leave&at=m2747703236%7E1.2747703242%7E3.2747703242_757284974_10961089_1256136758_1239828424_3048164_434512896_3074056939_211902
ConnectionError: request failed: CORS request rejected: https://matrix-client.matrix.org/_matrix/client/r0/rooms/!fQZDstnphEFtEhuPDt%3Amatrix.org/members?not_membership=leave&at=m2747703236%7E1.2747703242%7E3.2747703242_757284974_10961089_1256136758_1239828424_3048164_434512896_3074056939_211902
    at vector://vector/webapp/bundles/25c2586213e8b3c859f0/init.js:54344:15
    at Object.callback (vector://vector/webapp/bundles/25c2586213e8b3c859f0/init.js:54277:9)
    at on_response (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:209393:22)
    at XMLHttpRequest.on_state_change (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:209369:7)
    at XMLHttpRequest.<anonymous> (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:191560:41)
2022-03-05T15:17:09.815Z E Error configuring encryption in room !fQZDstnphEFtEhuPDt:matrix.org: request failed: CORS request rejected: https://matrix-client.matrix.org/_matrix/client/r0/rooms/!fQZDstnphEFtEhuPDt%3Amatrix.org/members?not_membership=leave&at=m2747703236%7E1.2747703242%7E3.2747703242_757284974_10961089_1256136758_1239828424_3048164_434512896_3074056939_211902
ConnectionError: request failed: CORS request rejected: https://matrix-client.matrix.org/_matrix/client/r0/rooms/!fQZDstnphEFtEhuPDt%3Amatrix.org/members?not_membership=leave&at=m2747703236%7E1.2747703242%7E3.2747703242_757284974_10961089_1256136758_1239828424_3048164_434512896_3074056939_211902
    at vector://vector/webapp/bundles/25c2586213e8b3c859f0/init.js:54344:15
    at Object.callback (vector://vector/webapp/bundles/25c2586213e8b3c859f0/init.js:54277:9)
    at on_response (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:209393:22)
    at XMLHttpRequest.on_state_change (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:209369:7)
    at XMLHttpRequest.<anonymous> (vector://vector/webapp/bundles/25c2586213e8b3c859f0/vendors~init.js:191560:41)

We should work out what the correct behaviour is for starting up offline, although given this doesn't seem to be new, I don't think it's a release blocker.

@dbkr dbkr added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed X-Release-Blocker labels Mar 8, 2022
@germain-gg germain-gg removed their assignment Mar 8, 2022
@novocaine novocaine added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 8, 2022
@novocaine
Copy link
Contributor

if its network, duplicate of #21052

su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this issue Mar 17, 2022
@su-ex
Merge tag 'v16.0.0' into sc
8daa03b 
* Improve typing around event emitter handlers ([\matrix-org#2180](matrix-org#2180)).
* Fix defer not supporting resolving with a Promise<T> ([\matrix-org#2216](matrix-org#2216)).
* add LocationAssetType enum ([\matrix-org#2214](matrix-org#2214)).
* Support for mid-call devices changes ([\matrix-org#2154](matrix-org#2154)). Contributed by @SimonBrandner.
* Add new room state emit RoomStateEvent.Update for lower-frequency hits ([\matrix-org#2192](matrix-org#2192)).
* Fix wrong event_id being sent for m.in_reply_to of threads ([\matrix-org#2213](matrix-org#2213)).
* Fix wrongly asserting that PushRule::conditions is non-null ([\matrix-org#2217](matrix-org#2217)).
* Make createThread more resilient when missing rootEvent ([\matrix-org#2207](matrix-org#2207)). Fixes element-hq/element-web#21130.
* Fix bug with the /hierarchy API sending invalid requests ([\matrix-org#2201](matrix-org#2201)). Fixes element-hq/element-web#21170.
* fix relation sender filter ([\matrix-org#2196](matrix-org#2196)). Fixes element-hq/element-web#20877.
* Fix bug with one-way audio after a transfer ([\matrix-org#2193](matrix-org#2193)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Critical Prevents work, causes data loss and/or has no workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
5 participants
@novocaine @germain-gg @dbkr @ara4n @t3chguy