Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read receipts fly from the sky now #17561

Closed
turt2live opened this issue Jun 4, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6169
Closed

Read receipts fly from the sky now #17561

turt2live opened this issue Jun 4, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#6169
Assignees
@jryans
Labels
A-Read-Receipts P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@turt2live
Copy link
Member

even if the message they are falling from is immediately prior
@robintown
Copy link
Member

Duplicate of #17557

@t3chguy
Copy link
Member

t3chguy commented Jun 4, 2021

#17557 says read marker, that's the green horizontal line

@t3chguy t3chguy mentioned this issue Jun 4, 2021
Closed
@SimonBrandner SimonBrandner added A-Read-Receipts P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Regression T-Defect labels Jun 5, 2021
@DantrazTrev DantrazTrev mentioned this issue Jun 7, 2021
Closed
@jryans jryans self-assigned this Jun 9, 2021
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 9, 2021
@jryans
Restore read receipt animation from event to event
b43315c 
This restores expected read receipt animation by always including the positioned
parent of read receipts. I imagine there's something smarter we could be doing,
but for now, at least least get back to expected behaviour.

Fixes element-hq/element-web#17561
@jryans jryans mentioned this issue Jun 9, 2021
Merged
@germain-gg germain-gg mentioned this issue Aug 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Read-Receipts P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore read receipt animation from event to event matrix-org/matrix-react-sdk
5 participants
@jryans @turt2live @t3chguy @SimonBrandner @robintown