Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template variables for display name and such don't apply on widgets anymore? #12985

Closed
turt2live opened this issue Apr 1, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4366
Closed

Template variables for display name and such don't apply on widgets anymore? #12985

turt2live opened this issue Apr 1, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4366
Assignees
@turt2live

Comments

@turt2live
Copy link
Member

No description provided.

@turt2live
Copy link
Member Author

specifically custom widgets, eg: /addwidget https://example.org?name=$matrix_display_name

@t3chguy
Copy link
Member

t3chguy commented Apr 4, 2020

https://github.com/matrix-org/matrix-react-sdk/blob/5c2841323e58d5b22f488a3fc47607b9387a8463/src/components/views/elements/AppTile.js#L141 malforms $matrix_display_name into %24matrix_display_name

@turt2live turt2live self-assigned this Apr 8, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 8, 2020
@turt2live
Fix encoding of widget arguments
b5aaae1 
Fixes element-hq/element-web#12985

This is done by using a more modern API and de-encoding dollar signs.
@turt2live turt2live mentioned this issue Apr 8, 2020
Merged
This was referenced Apr 23, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix encoding of widget arguments matrix-org/matrix-react-sdk
2 participants
@turt2live @t3chguy