Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prompt for secret storage key immediately after creation #12867

Closed
foldleft opened this issue Mar 25, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4308
Closed

prompt for secret storage key immediately after creation #12867

foldleft opened this issue Mar 25, 2020 · 2 comments · Fixed by matrix-org/matrix-react-sdk#4308
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@foldleft
Copy link
Contributor

i created a new account and set up secret storage with a key. i was immediately prompted to enter it again to unlock secret storage. nb this will likely go away on the completion of #12704 since that does caching, so this ticket is mostly likely to entail double-checking that actually happened
@foldleft
Copy link
Contributor Author

possibly related to #12892

@foldleft foldleft mentioned this issue Mar 26, 2020
Closed
@bwindels
Copy link
Contributor

bwindels commented Mar 27, 2020 •
edited
Loading

@BillCarsonFr hit this on new account creation, additionally also saw a "Verify this session" toast after login. See https://matrix.to/#/!HhZHxURiCDviGNNPnc:matrix.org/$3w_GOGOHrhCnxd2I5X05isuCV4MGCvGTHTdet8gFKFc?via=matrix.org

@jryans jryans self-assigned this Mar 30, 2020
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Mar 30, 2020
@jryans
Receive private key for caching from the app layer
9a1d624 
This passes through the new secret storage key as well as the key info so that
bootstrap can use it immediately without triggering an immediate prompt.

Part of element-hq/element-web#12867
@jryans jryans mentioned this issue Mar 30, 2020
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 30, 2020
@jryans
Pass new secret storage key to bootstrap path
690b594 
This passes the newly created secret storage key down to the bootstrap path for
temporary caching to avoid prompting the user for it again in the later stages
of bootstrapping.

Fixes element-hq/element-web#12867
@jryans jryans mentioned this issue Mar 30, 2020
Merged
t3chguy pushed a commit that referenced this issue Oct 17, 2024
@dbkr
Update settings tab icons (#12867)
6ca4f67 
* Change icon for general/account tab

...and add support for compound design token icons to TabbedView,
changing all the other icons over while we're at it.

* Update snapshots

* Fix responsive mode

* Missed one

* truthy-check the whole block

* Use asset imports

* Update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass new secret storage key to bootstrap path matrix-org/matrix-react-sdk
3 participants
@bwindels @jryans @foldleft