-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If you switch away from the room where you're verifying someone in the RightPanel you may never be able to finish the verification. #12859
Comments
The issue seems to be that her device thought she had already verified you. I'm not sure how that would happen. @AmandineLP When you went again to your member info, all Matthew's session were green and there was no verify button? I asked Amandine to rageshake.
Hmm, could do, that would prevent you though from looking at the member info while a verification request is ongoing. If we add this, we should definitely pair it with fixing #12860 |
Yes. Because she'd already cross-signed me, i assume? But i'd presumably lost my cross-signing state at some point, or had de-trusted her, hence me wanting to re-verify her. |
But if she had already cross-signed you, why (and how) did you send here a request in the first place? Did you send a request to a device she hadn't cross-signed herself yet? Or did she cross-sign you but you hadn't cross-signed her yet? |
Because my client was not showing her as cross-signed.
The latter, i think. |
I see. So this can be summarized as "If you send a verification request to somebody who has already verified you, they accept, but then navigate elsewhere, then they have no way to get back to the request as the member info won't show the verify button anymore" So yeah, in this case, we should either we still show the verify button, or show the encryption panel straight away when clicking the member in the member list. I'd personally prefer the former, as it will still allow you to see the member info while a request is ongoing. Wdyt? |
Had a call with Nad and he agreed to go straight to the verification request if you click a member in the memberlist with whom you have an ongoing verification request. |
…12859) * Clear settings caches on reset Signed-off-by: Michael Telatynski <[email protected]> * Derp Signed-off-by: Michael Telatynski <[email protected]> * Delint Signed-off-by: Michael Telatynski <[email protected]> --------- Signed-off-by: Michael Telatynski <[email protected]>
Additionally, if she hadn't verified me, she would have had to have (unintuitively) hit the 'verify' button again to resume the verification - shouldn't it take you straight back in when you open MemberInfo?
The text was updated successfully, but these errors were encountered: