Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you switch away from the room where you're verifying someone in the RightPanel you may never be able to finish the verification. #12859

Closed
ara4n opened this issue Mar 24, 2020 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4284

Comments

@ara4n
Copy link
Member

ara4n commented Mar 24, 2020

  • I tried to verify Amandine
  • She clicked on the toast and went to a random DM where she started the interactive verification dance in the RightPanel.
  • She then switched room, and lost the RightPanel
  • She then went to my MemberInfo, hoping to get back into the verification.
  • Instead, because her device thinks she's already verified me, she had no way to resume it.

Additionally, if she hadn't verified me, she would have had to have (unintuitively) hit the 'verify' button again to resume the verification - shouldn't it take you straight back in when you open MemberInfo?

@bwindels
Copy link
Contributor

The issue seems to be that her device thought she had already verified you. I'm not sure how that would happen. @AmandineLP When you went again to your member info, all Matthew's session were green and there was no verify button? I asked Amandine to rageshake.

Additionally, if she hadn't verified me, she would have had to have (unintuitively) hit the 'verify' button again to resume the verification - shouldn't it take you straight back in when you open MemberInfo?

Hmm, could do, that would prevent you though from looking at the member info while a verification request is ongoing. If we add this, we should definitely pair it with fixing #12860

@ara4n
Copy link
Member Author

ara4n commented Mar 25, 2020

The issue seems to be that her device thought she had already verified you. I'm not sure how that would happen. @AmandineLP When you went again to your member info, all Matthew's session were green and there was no verify button? I asked Amandine to rageshake.

Yes. Because she'd already cross-signed me, i assume? But i'd presumably lost my cross-signing state at some point, or had de-trusted her, hence me wanting to re-verify her.

@bwindels
Copy link
Contributor

But if she had already cross-signed you, why (and how) did you send here a request in the first place? Did you send a request to a device she hadn't cross-signed herself yet? Or did she cross-sign you but you hadn't cross-signed her yet?

@ara4n
Copy link
Member Author

ara4n commented Mar 25, 2020

But if she had already cross-signed you, why (and how) did you send her a request in the first place?

Because my client was not showing her as cross-signed.

Did you send a request to a device she hadn't cross-signed herself yet? Or did she cross-sign you but you hadn't cross-signed her yet?

The latter, i think.

@bwindels
Copy link
Contributor

I see. So this can be summarized as "If you send a verification request to somebody who has already verified you, they accept, but then navigate elsewhere, then they have no way to get back to the request as the member info won't show the verify button anymore"

So yeah, in this case, we should either we still show the verify button, or show the encryption panel straight away when clicking the member in the member list. I'd personally prefer the former, as it will still allow you to see the member info while a request is ongoing. Wdyt?

@bwindels bwindels self-assigned this Mar 26, 2020
@bwindels
Copy link
Contributor

Had a call with Nad and he agreed to go straight to the verification request if you click a member in the memberlist with whom you have an ongoing verification request.

t3chguy added a commit that referenced this issue Oct 17, 2024
…12859)

* Clear settings caches on reset

Signed-off-by: Michael Telatynski <[email protected]>

* Derp

Signed-off-by: Michael Telatynski <[email protected]>

* Delint

Signed-off-by: Michael Telatynski <[email protected]>

---------

Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants