Riot web seems ignores ordering in tagged rooms (favourites)

[babolivier]

A change that happened today on /develop apparently resulted in some of my tagged rooms to be displayed out of order (I use the "Group & filter rooms by custom tags" labs feature, though that also happens with favourite rooms).

This means that, for a newvector tag, the room with this account data:

{
  "type": "m.tag",
  "content": {
    "tags": {
      "newvector": {
        "order": 0.19444444444444442
      }
    }
  }
}

is displayed before the one with this account data:

{
  "type": "m.tag",
  "content": {
    "tags": {
      "newvector": {
        "order": 0.08333333333333333
      }
    }
  }
}

which, while it doesn't seem to be explicitly forbidden by the spec, seems to go in the opposite direction and is quite counter intuitive (https://matrix.org/docs/spec/client_server/r0.6.0#id123).

[turt2live]

What does tags.t2bot.io show you for the rooms? There's a chance that the tombstoned rooms are being sorted into a different position than what you'd expect.

[t3chguy]

Its because of

#12242 (comment)

Soo all sections which are not Favourites are now recents/alphabetically sorted.

[turt2live]

I'm not sure Nad was necessarily aware that it would affect custom tags too, and the top post says it's happening to favourites.

[babolivier]

Soo all sections which are not Favourites are now recents/alphabetically sorted.

Oh. Can't we just do that for all rooms that aren't tagged? It's pretty annoying as I got all of my company rooms organised for quick access to the ones I use the most frequently :/

Also, this definitely affects favourites, some of my favourite rooms are now out of order.

[turt2live]

A rageshake would also be nice as there's logging for this sort of thing.

[babolivier]

A rageshake would also be nice as there's logging for this sort of thing.

Done.

[t3chguy]

I cannot reproduce:

[turt2live]

thanks, fortunately the rageshake doesn't have the logging in it which means it's not some obscure bug with the list.

If you can, please test with another client that supports manual ordering (that isn't in the Riot family) like Quaternion or https://tags.t2bot.io - at least for favourites the ordering should be stable.

[babolivier]

If you can, please test with another client that supports manual ordering (that isn't in the Riot family) like Quaternion or https://tags.t2bot.io - at least for favourites the ordering should be stable.

Yep, still waiting for it to load my rooms, will bing back here when it does.

[turt2live]

I've opened #12572 for the custom tags side of this ftr

[babolivier]

tags.t2bot.io shows me the rooms ordered in the right order. Here's the comparison of what's shown for in both tags.t2bot.io and Riot for my tag for the public matrix.org rooms I'm in, but I've also checked that it differs both with this tag, my newvector one and my favourites.

[t3chguy]

Yes, it is known custom tags lost manual ordering, that's #12572
Which was a conscious effort on my part based on Nad's instructions.

This issue is about Favourites tagged stuff which should still be manually ordered as shown above in my screenshot.

[babolivier]

Ah right, sorry.

Anyway, I'm not going to post a screenshot here of my favourite rooms because some of them are private but their ordering also differs between tags.t2bot.io and Riot.

[turt2live]

Summary of this is that riot-web is indeed doing something weird with the favourites, but not for me or t3chguy.

Suggestion is to try and use tags.t2bot.io to reset the tag ordering which might make riot-web less confused.

[bhauer]

I'm not sure I follow the nuances in this thread, but I want to add that as a user of Riot, I would really appreciate an option to alphabetize the favorites list.

[t3chguy]

@bhauer thats #4484

[turt2live]

We now intentionally ignore manual ordering by default. It's more stable now, and should be more helpful.