Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor leaked DOM trees #12482

Open
ara4n opened this issue Feb 24, 2020 · 0 comments
Open

Monitor leaked DOM trees #12482

ara4n opened this issue Feb 24, 2020 · 0 comments

Comments

@ara4n
Copy link
Member

ara4n commented Feb 24, 2020

After the fun of #12417, it's become clear that it's way too easy for us to leak DOM trees by failing to clean up event listeners correctly, leaking promises, or failing to unmount manually mounted React components - and that it's a pain in the ass to diagnose when it happens.

I think it might be prudent to track the number of trees we have instantiated at any given point - e.g. by maintaining a global refcount on MessageComposer or something, and have it displayed somewhere on /develop (like, physically visible all the time), so developers spot when they've suddenly started to leak trees, rather than relying on everyone constantly doing heap snapshots (or keeping a constant eye for slow leaks).

@ara4n ara4n added the T-Defect label Feb 24, 2020
@jryans jryans changed the title Monitor leaked DOM trees. Monitor leaked DOM trees Feb 24, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
…ed (#12482)

* Update `@vector-im/compound-web`

* Update TAC snapshots

* Update space panel snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants