Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite dialog will refuse to match an exact user ID if the server returned results #12419

Closed
turt2live opened this issue Feb 19, 2020 · 3 comments · Fixed by matrix-org/matrix-react-sdk#4099

Comments

@turt2live
Copy link
Member

This makes it impossible to invite @telegram:t2bot.io to a room because matrix.org (for example) will return ~15 Telegram users but not actually the bot you've asked for.

@ara4n
Copy link
Member

ara4n commented Feb 19, 2020

returned no results surely?

@ara4n
Copy link
Member

ara4n commented Feb 19, 2020

well, it refuses to match exact user IDs whether there were results or not...

@turt2live
Copy link
Member Author

No, the code doesn't try exact matches when the server does return results, as it expects the server to figure this out:
image

However Synapse doesn't always do something as convenient as shown in the above screenshot:
image

So unless you have interacted with certain users before, it won't suggest anything. However, when the server returns no results (because you don't share a room with the user, or they aren't public, etc) the dialog takes a bit of time to track down a profile and fill in the gap for you:
image

The fix is that when you enter a mxid-looking thing it should always track down a profile and push the result to the top of the suggestions. If the server happens to return the result it's looking for, it should just move the entry to the top (skipping the profile check because it would already have one).

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Feb 21, 2020
t3chguy pushed a commit that referenced this issue Oct 17, 2024
)

* Make empty state copy for TAC depend on the value of the setting

* Update test snapshot

* Fix snapshot

Run the whole file or the radix IDs will br wrong 🤦

* Simplify to a ternary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants