Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pills, autocomplete, etc all don't work without alias events #12364

Closed
turt2live opened this issue Feb 13, 2020 · 11 comments · Fixed by matrix-org/matrix-react-sdk#4102
Closed

Comments

@turt2live
Copy link
Member

The spec says we shouldn't rely on m.room.aliases, but we need them to render pills.

@turt2live
Copy link
Member Author

Also the cache becomes outdated when aliases change, so pointing at a new room doesn't work.

@turt2live turt2live changed the title Pills don't work without alias events Pills, autocomplete, etc all don't work without alias events Feb 13, 2020
@turt2live
Copy link
Member Author

also affects autocomplete.

@richvdh
Copy link
Member

richvdh commented Feb 14, 2020

on the subject of pills: related to #430

@ara4n
Copy link
Member

ara4n commented Feb 14, 2020

why do we need m.room.aliases to render pills?

@turt2live
Copy link
Member Author

So that when someone sends <a href='https://matrix.to/#/!roomid:exmaple.org'>text</a> it shows #matrix:matrix.org.

@richvdh
Copy link
Member

richvdh commented Feb 19, 2020

also also: you can't set a new room to "anyone can join":

image

@richvdh
Copy link
Member

richvdh commented Feb 19, 2020

aiui: the current plan here is to forge ahead with #12337

@bwindels
Copy link
Contributor

bwindels commented Feb 19, 2020

So which alias should we use for pills? The canonical alias, if any, otherwise the first of alt_aliases, if any?

@bwindels
Copy link
Contributor

for autocomplete: complete for all aliases (alt_aliases, canonical, and local aliases)
for pill: first canonical, then alt_aliases, then probably local aliases

@turt2live
Copy link
Member Author

^this should be pretty much what we already do ftr

@bwindels
Copy link
Contributor

bwindels commented Feb 21, 2020

After some discussion on #msc2432:matrix.org, I didn't add local alias support to pills and autocomplete. The label of a pill will be left alone though for a local alias and will still appear in a pill (albeit without avatar), see linked PRs.

t3chguy pushed a commit that referenced this issue Oct 17, 2024
* Use test helpers from js-sdk for encrypted events

Rather than gut-wrenching into the matrix-js-sdk, let's use the newly-exported
test helpers to generate encrypted events.

* Fix up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants