-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unclear purpose of 2nd room list #12329
Labels
Comments
t3chguy
pushed a commit
that referenced
this issue
Oct 17, 2024
* Order room by thread timestamp * Fix key errors in test * Update jest snapshots * Update snapshots * Rename alpha/beta to numbers * Add playwright test
JohnSimonsen
pushed a commit
to verji/element-web-v2
that referenced
this issue
Dec 20, 2024
* Update `@vector-im/compound-design-tokens` in package.json (element-hq#12339) * Change 'type' prop on badges to 'forceDot' (element-hq#12327) * Change 'type' prop on badges tio 'forceDot' Which, hopefully, better represents what it actually does. Tidies up some of the logic. Split out from matrix-org/matrix-react-sdk#12254 * Missed a file * More comments * Oops, there is no count here. * Back out the logic refactor of StatelessNotificationBadge because it was also updating the logic for mark as unread badges and rewriting the ternary to the previous logic would be quite complex. * Fix doc comment Co-authored-by: Richard van der Hoff <[email protected]> * Clarify doc on displaying the count * Update doc for the forceDot param here too. --------- Co-authored-by: Richard van der Hoff <[email protected]> * [Backport staging] Update `@vector-im/compound-design-tokens` in package.json (element-hq#12340) (cherry picked from commit e3ba643) Co-authored-by: Florian Duros <[email protected]> * Fix the image view (element-hq#12341) * TAC: Fix hover state when expanded (element-hq#12337) * Fix TAC hover state * Add playwright test * Update playwright snapshot after last compound style changes * v3.95.0-rc.0 * v3.95.0 * Reset matrix-js-sdk back to develop branch * TAC: Order rooms by most recent after notification level (element-hq#12329) * Order room by thread timestamp * Fix key errors in test * Update jest snapshots * Update snapshots * Rename alpha/beta to numbers * Add playwright test * Replace forceCount prop with hideIfDot (element-hq#12344) This replaces the `forceCount` prop on room badge components with `hideIfDot` which hopefully gives a better idea of what it does, since forceCount did not really force a count. Also remove the prop where it was just passing the default value anyway. --------- Co-authored-by: Florian Duros <[email protected]> Co-authored-by: David Baker <[email protected]> Co-authored-by: Richard van der Hoff <[email protected]> Co-authored-by: ElementRobot <[email protected]> Co-authored-by: Robin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Referring to #12279 for base information
Above the "explore button" there is a list of icons of rooms.
First it is unclear why it is there (what is the purpose?) and secondly it has a very weird horizontal scroll bar.
As a user it is unclear what I should be doing, how it is different from the other list.
The text was updated successfully, but these errors were encountered: