-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution for solve issue of breadcrumbs implementation #12200
Labels
Comments
ghost
added
the
T-Enhancement
label
Feb 2, 2020
This sounds exactly like threads, which we now have. |
t3chguy
pushed a commit
that referenced
this issue
Oct 17, 2024
* Add `Thread Activity centre` labs flag * Rename translation string * WIP Thread Activity Centre * Update supportedLevels * css lint * i18n lint * Fix labs subsection test * Update Threads Activity Centre label * Rename Thread Activity Centre to Threads Activity Centre * Use compound `MenuItem` instead of custom button * Color thread icon when hovered * Make the pop-up scrollable and add a max height * Remove Math.random in key * Remove unused class * Change add comments on `mx_ThreadsActivityRows` and `mx_ThreadsActivityRow` * Make threads activity centre labs flag split out unread counts Just shows notif & unread counts for main thread if the TAC is enabled. * Fix tests * Simpler fix * Open thread panel when thread clicke in Threads Activity Centre Hopefully this is a sensible enough way. The panel will stay open of course (ie. if you go to a different room & come back), but that's the nature of the right panel. * Dynamic state of room * Add doc * Use the StatelessNotificationBadge component in ThreadsActivityCentre and re-use the existing NotificationLevel * Remove unused style * Add room sorting * Fix `ThreadsActivityRow` props doc * Pass in & cache the status of the TAC labs flag * Pass includeThreads as setting to doesRoomHaveUnreadMessages too * Fix tests * Add analytics to the TAC (#12179) * Update TAC label (#12186) * Add `IndicatorIcon` to the TAC button (#12182) Add `IndicatorIcon` to the TAC button * Threads don't have activity if the room is muted This makes it match the computation in determineUnreadState. Ideally this logic should all be in one place. * Re-use doesRoomHaveUnreadThreads for useRoomThreadNotifications This incorporates the logic of not showing unread dots if the room is muted * Add TAC description in labs (#12197) * Fox position & size of dot on the tac button IndicatorIcon doesn't like having the size of its icon adjusted and we probably shouldn't do it anyway: better to specify to the component what size we want it. * TAC: Utils tests (#12200) * Add tests for `doesRoomHaveUnreadThreads` * Add tests for `getThreadNotificationLevel` * Add test for the ThreadsActivityCentre component * Add snapshot test * Fix narrow hover background on TAC button Make the button 32x32 (and the inner icon 24x24) * Add caption for empty TAC * s/tac/threads_activity_centre/ * Fix i18n & add tests * Add playwright tests for the TAC (#12227) * Fox comments --------- Co-authored-by: David Baker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
** I heard before in matrix live from some members of the matrix.org team, questioning if breadcrumbs should be implemented by default or not. So will present a solution that will not be necessary to implement breadcrumbs by default. But can fix the issue that breadcrumbs is trying to solve. **
So the problem that is causing problems, is when some post starts a new prolonged discussion, and because this is taking place, the room ends up in a way being "spammed", My proposal would make this problem go way, not having the need to implement the breadcrumbs feature has a default. Because this would fix it in a more practical and intuitive way.
** So my proposal is to create a drop-down button/interaction, when somebody responds to a specific issue (so the person that posted the originally would have the option to concatenate it). So basically would be like the sub feature of raddle/reddit. Or the drop-down feature of youtube comments. **
When you would press to reply, your answer would go inside this drop-down "sub-thread" and it would be closed/pushed-up by default. Once you click the button/feature, the conversation related(replied) to that post, would drop-down between to lines (has shown in the picture in attachments). Making it possible for other people to continue with other conversations in the room, while not spamming the whole room, with a conversation that might not be relevant for many of the room members.
P.S. Would be more practical if the matrix.org back-end (protocol edit feature) would be used to show the latest response, instead of just the original post, so people with the conversation hidden can still follow it (you would have the original question/suggestion and then the latest response to it), while having the possibility to post new subjects.
(also maybe if the dropdown feature could be on or off by default depending on the number of room members, so if the room has more than 35 members make it on(hidde answers) by default, while if less then 35 members make it off(show all answers)by default).
** Edit and breadcrumbs feature. **
This features could solve the problem, but for example (has discussed by the team before, making it a default would not be the best move for a user-friendly/intuitive experience) the breadcrumb could be helpful in solving the problem but more geared toward power user and not the everyday user.
** Additional context. **
Of course this could be done just by rethinking the way the breadcrumb feature is used or by extension to it, but so its easier the understatement of my proposal. Preferred to call it a separate feature (though again is just a re-implementation/extension of the breadcrumb feature with assistance of the edit feature).
Here I presented a template of what I'm suggesting being the situation on the left the default position of the toggle/drop-down button the middle one when text is appearing and growing from hidden to a drop-down and them finally the situation on the right the "on switch" situation.
.
The text was updated successfully, but these errors were encountered: