Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine submit_url handling to only activate with separate add and bind #10936

Closed
jryans opened this issue Sep 23, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3583
Closed

Refine submit_url handling to only activate with separate add and bind #10936

jryans opened this issue Sep 23, 2019 · 0 comments · Fixed by matrix-org/matrix-react-sdk#3583
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Defect

Comments

@jryans
Copy link
Collaborator

jryans commented Sep 23, 2019

Currently Riot Web will fallback to the IS when submit_url is not received from the HS after requestToken. We may want to refine this so that we only fallback to the IS when binding or when using (old style) entangled add and bind, so that there's less chance of accidentally using an IS.
@jryans jryans self-assigned this Oct 31, 2019
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 31, 2019
@jryans
Guard against misconfigured homeservers when adding / binding phone n…
b38c7fc 
…umbers

This ensures we only fallback to submitting MSISDN tokens to the identity server
when we expect to do. Unexpected cases will now throw an error.

Fixes element-hq/element-web#10936
@jryans jryans mentioned this issue Oct 31, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
1 participant
@jryans