Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riot-web implements m.login.password UI auth incorrectly #10312

Closed
richvdh opened this issue Jul 11, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3211
Closed

riot-web implements m.login.password UI auth incorrectly #10312

richvdh opened this issue Jul 11, 2019 · 5 comments · Fixed by matrix-org/matrix-react-sdk#3211
Assignees
@turt2live
Labels
P1 T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec

Comments

@richvdh
Copy link
Member

richvdh commented Jul 11, 2019 •
edited
Loading

The spec says that the client should submit a dict including an identifier object. In practice riot-web just sends a user field.

Fixing this is blocked by fixing the synapse end (matrix-org/synapse#5665)
@richvdh richvdh mentioned this issue Jul 11, 2019
Closed
@turt2live
Copy link
Member

turt2live commented Jul 11, 2019 •
edited
Loading

Is this on register or sometime else?

@richvdh
Copy link
Member Author

richvdh commented Jul 11, 2019

I noticed it on device deletion. m.login.password isn't used for register, because you don't have a password to authenticate with at that point.

@turt2live
Copy link
Member

Good point. This is probably broken for several places because we don't use a common library for it

@anoadragon453
Copy link
Member

anoadragon453 commented Jul 11, 2019 •
edited
Loading

The correct behaviour seems to be implemented on logging in from /#/login.

@turt2live
Copy link
Member

Login doesn't use UIA.

@turt2live turt2live added T-Defect defect P1 Z-Spec-Compliance An area where Element doesn't correctly implement the spec labels Jul 11, 2019
@turt2live turt2live self-assigned this Jul 11, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 11, 2019
@turt2live
Send the correct UIA alongside the wrong UIA for backwards comaptibility
862fb16 
Fixes element-hq/element-web#10312
@turt2live turt2live mentioned this issue Jul 11, 2019
Merged
@turt2live turt2live mentioned this issue Apr 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
P1 T-Defect Z-Spec-Compliance An area where Element doesn't correctly implement the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Send the correct UIA alongside the wrong UIA for backwards comaptibility matrix-org/matrix-react-sdk
3 participants
@turt2live @anoadragon453 @richvdh