Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If your HS is not available you can get two error message on the login screen #10017

Closed
lampholder opened this issue Jun 11, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3218
Closed

If your HS is not available you can get two error message on the login screen #10017

lampholder opened this issue Jun 11, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3218
Assignees
@turt2live
Labels
A-Login P1 T-Defect

Comments

@lampholder
Copy link
Member

image

Now that you can still try and login when the HS is down, you can get both the failed validation message and the failed login message telling you very similar things.
@lampholder
Copy link
Member Author

Not a release blocker I think

@lampholder lampholder added the P1 label Jun 11, 2019
@lampholder lampholder changed the title Double error! What does it mean! If you HS is not available you can get two error message on login screen Jun 11, 2019
@lampholder lampholder changed the title If you HS is not available you can get two error message on login screen If your HS is not available you can get two error message on the login screen Jun 11, 2019
@turt2live turt2live self-assigned this Jul 11, 2019
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 15, 2019
@turt2live
Check for liveliness on submission when the server was previously dead
c6a18b1 
Fixes element-hq/element-web#10017

Specifically the `return` at the end of the diff fixes the problem, but it seems worthwhile to check for liveliness when we know the server has been dead in previous attempts.
@turt2live turt2live mentioned this issue Jul 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Login P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for liveliness on submission when the server was previously dead matrix-org/matrix-react-sdk
2 participants
@turt2live @lampholder