Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entering a full MXID on login makes the spinner spin indefinitely #10014

Closed
jryans opened this issue Jun 11, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3092
Closed

Entering a full MXID on login makes the spinner spin indefinitely #10014

jryans opened this issue Jun 11, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3092
Assignees
@jryans
Labels
A-Login P1 T-Defect X-Regression X-Release-Blocker

Comments

@jryans
Copy link
Collaborator

jryans commented Jun 11, 2019

From @lampholder:

Entering a full mxid (such as @test.user.0392809438934:matrix.org) makes the spinner spin indefinitely with no obvious noise in the console/networking tab
@jryans jryans self-assigned this Jun 11, 2019
@jryans
Copy link
Collaborator Author

jryans commented Jun 11, 2019

This issue only occurs if you use a full MXID that resolves to the same HS as Riot's default HS.

@turt2live
Copy link
Member

This issue only occurs if you use a full MXID that resolves to the same HS as Riot's default HS.

giphy (1)

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 11, 2019
@jryans
Clear the login busy state after .well-known discovery
2109905 
This always clear the login busy state after .well-known discovery without
waiting for the resulting server config. This is important for the case where
the HS that a full MXID resolves to matches the default HS, as without it we'd
be stuck in a busy state forever.

Fixes element-hq/element-web#10014
@jryans jryans mentioned this issue Jun 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Login P1 T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear the login busy state after .well-known discovery matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live