Delight edit layout experiment #6384

gileluard · 2022-07-06T19:21:40Z

resolves #6079, resolves #6406, resolves #6407, resolves #6409, resolves #6510, resolves #6509

Scrolling:

Filter:

Edit layout:

Other context menus:

- First implementation

# Conflicts: # Riot/Generated/UntranslatedStrings.swift

- Update after reviews

- Added new analytics

- Last tweaks

- fixed theme issues

- fixed build after merge - renamed AllChats classes

- new Build settings newAppLayoutEnaled

- Removed the Pinned space feature

- Removed the All chats layout editor screen - Added feature flag - Added context menus

- Removed analytics used for IA test

github-actions · 2022-07-25T13:31:26Z

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/4UFsmf

- Code cleanup

codecov-commenter · 2022-07-25T16:18:50Z

Codecov Report

Merging #6384 (6326fd0) into develop (5b7eb99) will decrease coverage by 0.01%.
The diff coverage is 7.33%.

@@             Coverage Diff             @@
##           develop    #6384      +/-   ##
===========================================
- Coverage     6.18%    6.16%   -0.02%     
===========================================
  Files         1453     1462       +9     
  Lines       155874   157146    +1272     
  Branches     62626    63159     +533     
===========================================
+ Hits          9636     9689      +53     
- Misses      145844   147054    +1210     
- Partials       394      403       +9

Impacted Files	Coverage Δ
Config/BuildSettings.swift	`42.18% <ø> (ø)`
Riot/Categories/UIViewController.swift	`39.17% <0.00%> (-8.33%)`	⬇️
Riot/Generated/Images.swift	`54.76% <ø> (ø)`
Riot/Managers/Theme/Themes/DarkTheme.swift	`0.00% <0.00%> (ø)`
...iot/Modules/Common/Recents/RecentsViewController.m	`7.96% <0.00%> (ø)`
.../Recents/Service/Mock/MockRecentsListService.swift	`0.00% <0.00%> (ø)`
...Modules/Common/Recents/Views/RecentTableViewCell.m	`0.00% <0.00%> (ø)`
.../SectionHeaders/AllChatsFilterOptionListView.swift	`0.00% <0.00%> (ø)`
.../Modules/Common/SectionHeaders/SectionHeaderView.m	`1.71% <0.00%> (-0.09%)`	⬇️
...ot/Modules/Common/SectionHeaders/TabListView.swift	`0.00% <0.00%> (ø)`
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7eb99...6326fd0. Read the comment docs.

- Update after review

- Code cleanup

pixlwave

Amazing, very nicely separated with the BuildSetting here 👍

I've left comments inline (sorry there's quite a lot 🫣)

One thing I wasn't sure how to summarise inline though was that the use of recent(s) for breadcrumbs is a little bit confusing. Especially when you end up with RecentsDataSourceSectionTypeRecentRooms/RecentsListServiceSectionRecents where the recents lists has a recents section. Not sure if it would be too big a change at this point to use breadcrumbs everywhere though 😕.

Config/BuildSettings.swift

Riot/Assets/Images.xcassets/Home/home_fab_create_room.imageset/Contents.json

Riot/Modules/Common/Recents/RecentsViewController.m

Riot/Modules/Common/SectionHeaders/SectionHeaderView.m

Riot/Modules/Home/AllChats/AllChatsActionPanelView.xib

Riot/Modules/Common/SectionHeaders/TabListView.swift

Riot/Modules/TabBar/TabBarCoordinator.swift

Co-authored-by: Doug <[email protected]>

- Update after code review

…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment

- Changed Recents type to Breadcrumbs

- Update after code review

Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift

Riot/Modules/Home/AllChats/AllChatsViewController.swift

Riot/Modules/Common/SectionHeaders/TabListView.swift

pixlwave

Looking good to me! A few more small comments inline.

A couple of weird things I notices while testing:

Toolbar in landscape mode	Build flag off, dark theme selected when OS is in light mode (status bar fixed by #6506)

pixlwave · 2022-08-02T10:04:57Z

Riot/Modules/Application/LegacyAppDelegate.m

+    // Need to set `showAllRoomsInHomeSpace` to `true` for the new App Layout
+    if (BuildSettings.newAppLayoutEnaled)
+    {
+        RiotSettings.shared.showAllRoomsInHomeSpace = YES;
+    }


Unrelated to this PR, but I think if this happens, it would be nice to see metaspaces coming to mobile like we have on Web e.g. a "Chats outside of a space" space.

Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift

Riot/Modules/Common/Recents/Service/RecentsListServiceProtocol.swift

Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift

changelog.d/6079.wip.change

gileluard · 2022-08-02T13:22:30Z

Looking good to me! A few more small comments inline.

A couple of weird things I notices while testing:

Toolbar in landscape mode Build flag off, dark theme selected when OS is in light mode (status bar fixed by #6506)

Everything's fixed now. Nice catch! Thank you :)

- Update after code review

sonarcloud · 2022-08-02T13:30:30Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

pixlwave

Looks good to me. Great job 👏

gileluard · 2022-08-02T14:31:15Z

🎉🎉🎉

gileluard added 17 commits May 10, 2022 22:15

Delight: Edit layout experiment #6079

9937828

- First implementation

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

ad043d9

# Conflicts: # Riot/Generated/UntranslatedStrings.swift

Delight: Edit layout experiment #6079

01bf3ed

- Update after reviews

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

857f446

Delight: Edit layout experiment #6079

1f96dca

- Added new analytics

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

e58cd8f

Delight: Edit layout experiment #6079

d8e3a96

- Last tweaks

Delight: Edit layout experiment #6079

378bcd3

- fixed theme issues

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

5505e8c

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

95ca2fa

Delight: Edit layout experiment #6079

38ed032

- fixed build after merge - renamed AllChats classes

Feature flag new App Layout #6406

51b179a

- new Build settings newAppLayoutEnaled

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

4d3befc

Update All chats screen with latest design #6407

b01c4fe

- Removed the Pinned space feature

Update All chats screen with latest design #6407

c77a527

- Removed the All chats layout editor screen - Added feature flag - Added context menus

Update All chats screen with latest design #6407

d89e441

- Removed analytics used for IA test

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

bb12f9a

Update All chats screen with latest design #6407

7d2b5ab

- Code cleanup

gileluard added 3 commits July 27, 2022 11:14

Update All chats screen with latest design #6407

7d03718

- Update after review

Update All chats screen with latest design #6407

2531c9c

- Code cleanup

Merge branch 'develop' into gil/6079-Delight_Edit_layout_experiment

ad7e61f

gileluard marked this pull request as ready for review July 27, 2022 12:23

gileluard requested a review from pixlwave July 27, 2022 12:51

pixlwave reviewed Jul 29, 2022

View reviewed changes

gileluard and others added 4 commits August 1, 2022 11:46

Update Riot/Modules/Home/AllChats/AllChatsLayoutSettingsManager.swift

6326fd0

Co-authored-by: Doug <[email protected]>

Update All chats screen with latest design #6407

9d3c49a

- Update after code review

Merge branch 'gil/6079-Delight_Edit_layout_experiment' of github.com:…

75bf04f

…vector-im/element-ios into gil/6079-Delight_Edit_layout_experiment

Update All chats screen with latest design #6407

cd68bae

- Changed Recents type to Breadcrumbs

Update All chats screen with latest design #6407

6e93716

- Update after code review

gileluard requested a review from pixlwave August 1, 2022 16:09

Update All chats screen with latest design #6407

e0856fb

- Update after code review

pixlwave reviewed Aug 2, 2022

View reviewed changes

Riot/Modules/Common/Recents/Service/MatrixSDK/RecentsListService.swift Outdated Show resolved Hide resolved

Riot/Modules/Home/AllChats/AllChatsViewController.swift Show resolved Hide resolved

Riot/Modules/Common/SectionHeaders/TabListView.swift Show resolved Hide resolved

pixlwave reviewed Aug 2, 2022

View reviewed changes

Update All chats screen with latest design #6407

b778131

- Update after code review

gileluard requested a review from pixlwave August 2, 2022 13:29

pixlwave approved these changes Aug 2, 2022

View reviewed changes

gileluard merged commit 55d7c22 into develop Aug 2, 2022

gileluard deleted the gil/6079-Delight_Edit_layout_experiment branch August 2, 2022 15:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delight edit layout experiment #6384

Delight edit layout experiment #6384

gileluard commented Jul 6, 2022 •

edited

Loading

github-actions bot commented Jul 25, 2022 •

edited

Loading

codecov-commenter commented Jul 25, 2022 •

edited

Loading

pixlwave left a comment

pixlwave left a comment •

edited

Loading

pixlwave Aug 2, 2022

gileluard commented Aug 2, 2022

sonarcloud bot commented Aug 2, 2022

pixlwave left a comment

gileluard commented Aug 2, 2022

Delight edit layout experiment #6384

Delight edit layout experiment #6384

Conversation

gileluard commented Jul 6, 2022 • edited Loading

github-actions bot commented Jul 25, 2022 • edited Loading

codecov-commenter commented Jul 25, 2022 • edited Loading

Codecov Report

pixlwave left a comment

Choose a reason for hiding this comment

pixlwave left a comment • edited Loading

Choose a reason for hiding this comment

pixlwave Aug 2, 2022

Choose a reason for hiding this comment

gileluard commented Aug 2, 2022

sonarcloud bot commented Aug 2, 2022

pixlwave left a comment

Choose a reason for hiding this comment

gileluard commented Aug 2, 2022

gileluard commented Jul 6, 2022 •

edited

Loading

github-actions bot commented Jul 25, 2022 •

edited

Loading

codecov-commenter commented Jul 25, 2022 •

edited

Loading

pixlwave left a comment •

edited

Loading