Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display fallback when replied event content is partially missing #6372

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Display fallback when replied event content is partially missing #6372

merged 1 commit into from
Jul 4, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #6371

@aringenbach aringenbach requested review from a team and pixlwave and removed request for a team July 4, 2022 13:13
@github-actions
Copy link

github-actions bot commented Jul 4, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/SW8YDz

pixlwave
pixlwave approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to add a test for this scenario if its easy to setup.

@aringenbach aringenbach changed the base branch from develop to hotfix/1.8.20 July 4, 2022 14:55
@aringenbach aringenbach changed the base branch from hotfix/1.8.20 to develop July 4, 2022 14:56
@aringenbach aringenbach force-pushed the aringenbach/6371_display_fallback_missing_reply_content branch from 6a63546 to 29e7e5b Compare July 4, 2022 15:00
@aringenbach aringenbach changed the base branch from develop to hotfix/1.8.20 July 4, 2022 15:00
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aringenbach aringenbach merged commit e939e7c into hotfix/1.8.20 Jul 4, 2022
@aringenbach aringenbach deleted the aringenbach/6371_display_fallback_missing_reply_content branch July 4, 2022 15:01
@aringenbach aringenbach mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Constructed replies sometimes have an empty "(null)" replied content
2 participants
@aringenbach @pixlwave