Authentication: Verify MSISDN screen #6205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/uDgToZ |
pixlwave
reviewed
May 26, 2022
RiotSwiftUI/Modules/Authentication/VerifyMsisdn/AuthenticationVerifyMsisdnModels.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/VerifyMsisdn/AuthenticationVerifyMsisdnModels.swift
Show resolved
Hide resolved
.../Modules/Authentication/VerifyMsisdn/Coordinator/AuthenticationVerifyMsisdnCoordinator.swift
Outdated
Show resolved
Hide resolved
.../Modules/Authentication/VerifyMsisdn/Coordinator/AuthenticationVerifyMsisdnCoordinator.swift
Outdated
Show resolved
Hide resolved
...Modules/Authentication/VerifyMsisdn/Test/Unit/AuthenticationVerifyMsisdnViewModelTests.swift
Outdated
Show resolved
Hide resolved
...Modules/Authentication/VerifyMsisdn/Test/Unit/AuthenticationVerifyMsisdnViewModelTests.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/VerifyMsisdn/View/AuthenticationVerifyMsisdnOTPForm.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/VerifyMsisdn/View/AuthenticationVerifyMsisdnScreen.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Authentication/VerifyMsisdn/View/AuthenticationVerifyMsisdnScreen.swift
Outdated
Show resolved
Hide resolved
.../Modules/Authentication/VerifyMsisdn/Coordinator/AuthenticationVerifyMsisdnCoordinator.swift
Outdated
Show resolved
Hide resolved
pixlwave
reviewed
May 26, 2022
Comment on lines
+211
to
+216
| switch error { | ||
| case RegistrationError.invalidPhoneNumber: | ||
| authenticationVerifyMsisdnViewModel.displayError(.invalidPhoneNumber) | ||
| default: | ||
| authenticationVerifyMsisdnViewModel.displayError(.unknown) | ||
| } |
There was a problem hiding this comment.
For some reason I'd never twigged you can simply switch on an error like this without doing an as? RegistrationError 🤩
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6182