New loading indicators when creating a room #5946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
Anderas
force-pushed
the
andy/5606_create_indicators
branch
from
8aa0191
to
55c3749
Compare
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/mNLiKK |
Anderas
commented
Mar 29, 2022
| @@ -115,6 +115,7 @@ final class EnterNewRoomDetailsViewModel: EnterNewRoomDetailsViewModelType { | |||
| fatalError("[EnterNewRoomDetailsViewModel] createRoom: room name cannot be nil.") | |||
| } | |||
|
|
|||
| viewState = .loading | |||
There was a problem hiding this comment.
I think this line was accidentally removed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5606
Use new interaction-blocking loading indicators when creating a new room. Note that this time the overlay is on top of the modal view controller (visible especially on an iPad) rather than over the full screen.
Whilst making this change I also noticed that the previously added UserIndicatorStore serves a similar purpose as an older
UserIndicatorPresenterWrapper. Because of this the latter is no longer need and can be removed.