Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SharedFont type to ElementFonts. #5646

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 21, 2022

Fixes #5027 by defining SwiftUI fonts natively alongside the UIKit fonts.

I've marked everything as available for iOS 13, so when iOS 12 support is dropped most of the properties can be be reverted back to 1 liners.

Using iOS 13 as availability so the properties can be simplified when support for iOS 12 is dropped.
Copy link
Member

@langleyd langleyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/rhP8wY

@pixlwave pixlwave merged commit a0a1d63 into develop Feb 21, 2022
@pixlwave pixlwave deleted the doug/5027_swiftui_fonts branch February 21, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Type in SwiftUI
2 participants