Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message bubbles: Use layout constants instead magic numbers #5588

Merged
merged 14 commits into from
Feb 16, 2022
Merged

Message bubbles: Use layout constants instead magic numbers #5588

merged 14 commits into from
Feb 16, 2022

Conversation

SBiOSoftWhare
Copy link
Contributor

Fix #5409

@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/BbPWTr

pixlwave
pixlwave approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, having bubble insets looks like it makes everything much simpler :)

Riot/Modules/Room/Views/BubbleCells/Styles/Bubble/BubbleRoomCellLayoutUpdater.swift Outdated
let messageViewMarginLeft: CGFloat = 80.0 + innerContentLeftMargin
let messageViewMarginRight: CGFloat = 78.0
let messageViewMarginLeft =
BubbleRoomCellLayoutConstants.outgoingBubbleBackgroundMargins.left + RoomBubbleCellLayout.innerContentViewMargins.left
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a double check that this is adding innerContentViewMargins whereas the right margins are adding bubbleTextViewInsets.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@pixlwave
Copy link
Member

Just noticed this one is missing a changelog.

@pixlwave pixlwave self-requested a review February 16, 2022 11:05
@SBiOSoftWhare SBiOSoftWhare merged commit 774acff into develop Feb 16, 2022
@SBiOSoftWhare SBiOSoftWhare deleted the steve/5409_bubbles_constants branch February 16, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message bubbles: Use layout constants instead magic numbers
2 participants
@SBiOSoftWhare @pixlwave