Scroll to the bottom of timeline automatically #5484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailgulek
reviewed
Feb 2, 2022
| // stay at the bottom if already was | ||
| if (self.isBubblesTableScrollViewAtTheBottom) | ||
| // re-scroll to the bottom, if at bottom before the most recent layout | ||
| if (self.shouldScrollToBottomAfterLayout) |
There was a problem hiding this comment.
Does it make sense to make shouldScrollToBottomAfterLayout false again after we scrolled to bottom?
There was a problem hiding this comment.
Good point. In practice it would not cause issues without (will/didLayout go in pair), but it will make it more explicit to reset.
Signed-off-by: Andy Uhnak <[email protected]>
Anderas
force-pushed
the
andy/4524-fix-timeline-scroll
branch
from
3afe6e4
to
0c6034e
Compare
ismailgulek
approved these changes
Feb 2, 2022
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WAt4Wm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4524
The
isBubblesTableScrollViewAtTheBottommethod was being used inviewDidLayoutSubviewsto determine, whether to scroll to the bottom-most bubble. The issue is however thatviewDidLayoutSubviewsmay change the size of the view, makingisBubblesTableScrollViewAtTheBottomgive the wrong result.To solve this we need to capture the value of
isBubblesTableScrollViewAtTheBottomduringviewWillLayoutand use that value inviewDidLayoutSubviews