Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash from potentially calling removeObserver multiple times. #4607

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Fix crash from potentially calling removeObserver multiple times. #4607

merged 2 commits into from
Jul 26, 2021

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jul 26, 2021 •
edited
Loading

Fixes #4606.

Remove the observer in destroy rather than viewDidDisappear so it only occurs once.

@pixlwave pixlwave merged commit 265c9e8 into develop Jul 26, 2021
@pixlwave pixlwave deleted the doug/4606_fix_authentication_crash branch July 26, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SBiOSoftWhare SBiOSoftWhare SBiOSoftWhare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App can crash on Login if a secondary view is presented before beginning authentication
2 participants
@pixlwave @SBiOSoftWhare