-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security settings: Improve the SECURE BACKUP section #4434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but this code is not used in production
like element-web.
This is a copy from SettingsKeyBackupTableViewSection. We need to get the current status of the key backup to be able to display right actions.
… unlocked Only from swift. We should change the name "SecretsRecovery" classes
It will overwrite the existing one if any
… backup description
…ase and Security Key #4268
The following build settings are no more managed:
@gileluard I wonder how we should proceed. Do we need this granularity? Cells for the "SECURE BACKUP" section are built in https://github.com/vector-im/element-ios/pull/4434/files#diff-26bb1cb392f51cc027e4f8d7fc4fde1388ddff100919f9fbd442972e6b9bfa55R126. |
ismailgulek
approved these changes
Jun 17, 2021
ismailgulek
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by making it work like element-web.
Fix #4430.
Require matrix-org/matrix-ios-sdk#1129.
This section now represents a mix of the secure backup (4S) state and the key backup state. The different combination are listed in
SettingsSecureBackupViewState
.In the nominal state, when secure backup and key backup and up, the 3 buttons do:
The "Set up" button can do 2 things:
All other possibilities can be found in the state rendering at https://github.com/vector-im/element-ios/pull/4434/files#diff-26bb1cb392f51cc027e4f8d7fc4fde1388ddff100919f9fbd442972e6b9bfa55R126.
I updated the
SecretsRecovery
flow, the one where we asked for Security phrase or key. We can now execute a random closure once the 4S has been locked and we got the private key. This is done with a newSecretsRecoveryGoal
enum case, which is pure swift. We should probably rename this flow toSecureBackupUnlock
.In term of implementation,
SettingsSecureBackupTableViewSection
is a copy and paste of theSettingsKeyBackupTableViewSection
we used 2y ago.Wording has been updated to match element-web one. Meanwhile, "Recovery Passphrase" and "Recovery Key" have been replace by "Security Phrase" and "Security Key" (Fix #4268).