Fix PushKit Crashes due to Undecryptable Call Invites #3989
Conversation
| dispatch_group_leave(dispatchGroup); | ||
| }]; | ||
|
|
||
| if (lastCallInvite.isEncrypted && ![session decryptEvent:lastCallInvite inTimeline:nil]) |
There was a problem hiding this comment.
I think this code (and the full block) should be in the handleBackgroundSyncCacheIfRequiredWithCompletion completion block.
decryptEvent will return false if keys are not yet transferred from bg sync caches to the MXSession stores.
If we do that, we will probably not need to call [session.callManager handleCallEvent:lastCallInvite];.
I may be wrong but I do not understand the usage of a dispatch_group_t here and the fact we use it for one step but not all.
There was a problem hiding this comment.
They're intentionally not in the completion block, because we should report the new call in the same run loop, which means we cannot do that async.
Handling to-device events seems sync (so i think decryptEvent should succeed), but handling timeline events is async, so i think it's still better to call [session.callManager handleCallEvent:lastCallInvite].
We also want to continue to sync after processing the cache, for data integrity. We're using dispatch_group_t to only wait for the completion.
There was a problem hiding this comment.
Got it. Thanks. I failed to understand because I thought the completion block allowed to be fully async :/
Can you add this information in comments, please?
Requires matrix-org/matrix-ios-sdk#1009
Fix #3986