-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home: Add empty screen when there is nothing to display #3824
Conversation
@SBiOSoftWhare looks good, thank you. Do you think I made a mistake with the text? Wonder if |
I think having an explanation of the + button is fine. Maybe |
// Check if some banners should be displayed | ||
if (recentsDataSource.secureBackupBannerSection != -1 || recentsDataSource.crossSigningBannerSection != -1) | ||
{ | ||
return YES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to check those banners? Why not checking only self. totalItemCounts ?
Plus I am not sure about the YES. I think NO is better.
If you have the secureBackupBannerSection, you have rooms. So, the room list is not empty
If you have crossSigningBannerSection, you are already on another device , you can have (and you probably) rooms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's an edge case. Maybe you added one encrypted room and then remove it. You can see the empty view and no more theses banners.
#3823