Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home: Add empty screen when there is nothing to display #3824

Merged
merged 6 commits into from
Nov 20, 2020

Conversation

SBiOSoftWhare
Copy link
Contributor

@niquewoodhouse
Copy link

niquewoodhouse commented Nov 20, 2020

@SBiOSoftWhare looks good, thank you. Do you think I made a mistake with the text?

Wonder if Tap the + to add people and rooms should be more explicit Tap the + below to get started?

@SBiOSoftWhare
Copy link
Contributor Author

@SBiOSoftWhare looks good, thank you. Do you think I made a mistake with the text?

Wonder if Tap the + to add people and rooms should be more explicit Tap the + below to get started?

I think having an explanation of the + button is fine. Maybe Tap the "+" button below to add people and rooms?

// Check if some banners should be displayed
if (recentsDataSource.secureBackupBannerSection != -1 || recentsDataSource.crossSigningBannerSection != -1)
{
return YES;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to check those banners? Why not checking only self. totalItemCounts ?

Plus I am not sure about the YES. I think NO is better.
If you have the secureBackupBannerSection, you have rooms. So, the room list is not empty
If you have crossSigningBannerSection, you are already on another device , you can have (and you probably) rooms.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's an edge case. Maybe you added one encrypted room and then remove it. You can see the empty view and no more theses banners.

@SBiOSoftWhare SBiOSoftWhare merged commit 79e36b6 into develop Nov 20, 2020
@SBiOSoftWhare SBiOSoftWhare deleted the element_3823 branch November 20, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants