Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's easy for the back button to trigger a leftpanel reveal #4438

Closed
ara4n opened this issue Jun 17, 2021 · 2 comments · Fixed by #4543
Closed

it's easy for the back button to trigger a leftpanel reveal #4438

ara4n opened this issue Jun 17, 2021 · 2 comments · Fixed by #4543

Comments

@ara4n
Copy link
Member

ara4n commented Jun 17, 2021

empirically, i keep triggering the leftpanel when tapping the back button. i think that if there's horizontal component to the tap, it gets interpretted as a swipe. can we disable/intercept the swipe on the back button and have it treated as a normal tap?

@ShadowJonathan
Copy link
Contributor

I'd rather have it so that a swipe is only "accepted" once the finger leaves the interaction area of the back button, i can see some interaction principles being broken if swiping is disabled entirely on and around the area of the back button, creating confusion for those not in the know.

@ara4n
Copy link
Member Author

ara4n commented Jun 28, 2021

If you only accepted the swipe when you swipe out of the backbutton area, you'd still have the problem that hitting the backbutton wouldn't do anything (other than move the screen slightly to the right and back again). I strongly suspect nobody tries to swipe at the top left where the backbutton is, and we should just disable the swiping there.

I hit this roughly 30% of the time i try to use the backbutton (i.e. my attempt to hit the backbutton is incorrectly seen as a swipe).

gileluard added a commit that referenced this issue Jul 9, 2021
gileluard added a commit that referenced this issue Jul 9, 2021
gileluard added a commit that referenced this issue Jul 9, 2021
gileluard added a commit that referenced this issue Jul 12, 2021
it's easy for the back button to trigger a leftpanel reveal (#4438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants