Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App crashes when entering a room after a call is hung-up just before being answered on the other end. #4403

Closed
langleyd opened this issue Jun 8, 2021 · 0 comments · Fixed by #4405
Assignees

Comments

@langleyd
Copy link
Member

langleyd commented Jun 8, 2021

App crashes when entering a room after a call is hung-up just before being answered on the other end.

It's difficult to reproduce the initial calling events that result in this issue.
Steps to reproduce the behaviour:

  1. Join a DM with two users.
  2. Request a call from one user.
  3. Accept call on one side around the same time that you hangup on the other side.
  4. Join this room with any iOS client.

Expected behaviour:
The app should not crash when joining the room but display the call history events.

Issue occurs just for iOS clients, on any iOS version.

Additional context
The problem is related to call timestamps, if the server returns a call start event time that is greater than the hangup time we get an integer overflow. The I think should gracefully handle this data as the other clients do.

@langleyd langleyd self-assigned this Jun 8, 2021
langleyd added a commit that referenced this issue Jun 9, 2021
Fix crash when entering a DM after a call is hung-up/rejected while being answered (#4403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant