Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should retry messages with same txn id when hitting 'resend' #1731

Closed
ara4n opened this issue Jan 11, 2018 · 0 comments
Closed

we should retry messages with same txn id when hitting 'resend' #1731

ara4n opened this issue Jan 11, 2018 · 0 comments
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint 8

Comments

@ara4n
Copy link
Member

ara4n commented Jan 11, 2018

No description provided.

@giomfo giomfo added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements P1 labels Jan 19, 2018
@manuroe manuroe added this to the Sprint 8 milestone Feb 19, 2018
@manuroe manuroe mentioned this issue Feb 19, 2018
Closed
manuroe added a commit to matrix-org/matrix-ios-sdk that referenced this issue Feb 26, 2018
@manuroe
BF: we should retry messages with same txn id when hitting 'resend' (e…
072ba56 
…lement-hq/element-ios#1731).

Use the local event id as the transaction id so that we will reuse the same transaction id if the user hits resend.
@manuroe manuroe mentioned this issue Feb 26, 2018
Merged
@manuroe manuroe closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint 8
Development

No branches or pull requests
3 participants
@ara4n @manuroe @giomfo