Merge pull request #5697 from vector-im/ismail/5694_scroll_bottom_fix

Room: Fix scrolling to bottom on back pagination
element-hq · Feb 25, 2022 · a87badf · a87badf
2 parents c4ddd37 + fff7fc6
commit a87badf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 9 deletions.
diff --git a/Riot/Modules/Room/DataSources/RoomDataSource.m b/Riot/Modules/Room/DataSources/RoomDataSource.m
@@ -29,7 +29,7 @@
 
 const CGFloat kTypingCellHeight = 24;
 
-@interface RoomDataSource() <BubbleReactionsViewModelDelegate, URLPreviewViewDelegate, ThreadSummaryViewDelegate>
+@interface RoomDataSource() <BubbleReactionsViewModelDelegate, URLPreviewViewDelegate, ThreadSummaryViewDelegate, MXThreadingServiceDelegate>
 {
     // Observe kThemeServiceDidChangeThemeNotification to handle user interface theme change.
     id kThemeServiceDidChangeThemeNotificationObserver;
@@ -92,12 +92,9 @@ - (instancetype)initWithRoomId:(NSString *)roomId andMatrixSession:(MXSession *)
             [self reload];
 
         }];
-
-        [[NSNotificationCenter defaultCenter] addObserver:self
-                                                 selector:@selector(newThreadCreated:)
-                                                     name:MXThreadingService.newThreadCreated
-                                                   object:nil];
-
+
+        [matrixSession.threadingService addDelegate:self];
+
         [self registerKeyVerificationRequestNotification];
         [self registerKeyVerificationTransactionNotification];
         [self registerTrustLevelDidChangeNotifications];
@@ -177,6 +174,8 @@ - (void)destroy
     {
         [[NSNotificationCenter defaultCenter] removeObserver:self.keyVerificationTransactionDidChangeNotificationObserver];
     }
+
+    [self.mxSession.threadingService removeDelegate:self];
 
     [super destroy];
 }
@@ -973,15 +972,20 @@ - (void)resetAccessibilityForCell:(MXKRoomBubbleTableViewCell *)cell
     cell.attachmentView.accessibilityLabel = nil;
 }
 
-#pragma mark - Threads
+#pragma mark - MXThreadingServiceDelegate
 
-- (void)newThreadCreated:(NSNotification *)notification
+- (void)threadingService:(MXThreadingService *)service didCreateNewThread:(MXThread *)thread direction:(MXTimelineDirection)direction
 {
     if (self.threadId)
     {
         //  no need to reload the thread screen
         return;
     }
+    if (direction == MXTimelineDirectionBackwards)
+    {
+        //  no need to reload when paginating back
+        return;
+    }
     NSUInteger count = 0;
     @synchronized (bubbles)
     {

diff --git a/changelog.d/5694.bugfix b/changelog.d/5694.bugfix
@@ -0,0 +1 @@
+RoomDataSource: Do not reload room data source on back pagination for new threads.