Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build element-io-archive-keyring package #565

Merged
merged 5 commits into from
Mar 9, 2023
Merged

Build element-io-archive-keyring package #565

merged 5 commits into from
Mar 9, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 7, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#24263
For #807

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Mar 7, 2023
@t3chguy t3chguy mentioned this pull request Mar 7, 2023
Closed
40 tasks
@t3chguy t3chguy changed the title Initial work towards keyring package building & consuming Build element-io-archive-keyring package Mar 8, 2023
@t3chguy t3chguy marked this pull request as ready for review March 8, 2023 15:31
@t3chguy t3chguy requested review from a team as code owners March 8, 2023 15:31
@t3chguy t3chguy requested review from justjanne and robintown March 8, 2023 15:31
@t3chguy t3chguy self-assigned this Mar 8, 2023
justjanne
justjanne approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@justjanne justjanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it feels a bit unclean to just pull the key from element.io

@t3chguy
Copy link
Member Author

t3chguy commented Mar 8, 2023 •
edited
Loading

LGTM, though it feels a bit unclean to just pull the key from element.io

Fair point, will add a fingerprint verification, this is based on Synapse's implementation

@t3chguy
Copy link
Member Author

t3chguy commented Mar 8, 2023

Actually, the keys are checked into the repo - DERP

https://github.com/vector-im/element-desktop/tree/develop/packages.element.io/debian

@t3chguy t3chguy requested a review from justjanne March 8, 2023 16:12
justjanne
justjanne approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@justjanne justjanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@t3chguy t3chguy merged commit 2bb999e into develop Mar 9, 2023
@t3chguy t3chguy deleted the t3chguy/keyring branch March 9, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justjanne justjanne justjanne approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @justjanne